-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VTOL: add parameter to set the PWM_OUTPUT_DEVICE_PATH #14732
Conversation
The device path is needed to apply PWM limits on the motors that are not used for FW flight (switch them off). With this parameter the device path can be set to either IO or FMU, depending on whether the motors are on the IO or FMU port. Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
@dagar or would you have a better idea instead of a parameter to achieve that? |
Nothing that isn't significantly more invasive. We'll find a better way to handle all of this holistically, but it's going to take some time. |
One way to (hopefully soonish) be able to solve it would be the control allocation. |
@sfuhrer Does this need docs? I would have said yes because what is written above is meaningless to me. My understanding was that allocation of outputs was defined by the mixer and includes MC stuff. So the need for this is unclear. |
@hamishwillee Historically the vtol controller was messing around with pwm outputs directly as the mixer interface was not designed for the functionality we need for vtol. |
@RomanBapst (& @sfuhrer ) The problem here is that the docs don't mention the limitation at all, so not really clear where this should be extended. I think "we" (meaning you :-) ) need to add a "VTOL Mixer" section under syntax explaining how you define a VTOL mixer - limitations/whatever and mentioning you need to set this parameter as well. Can you do that? I would do it but I bet there is more to it than just "define a multcopter mixer and an FW mixer(s), particularly for tailsitters etc. Though here is some idea of what it might look like.
Thoughts? |
@RomanBapst @sfuhrer ^^^^ Please see that last comment |
@hamishwillee I would propose something like this:
|
Thanks. Slightly modified version of your doc suggestion for review in PX4/PX4-Devguide#1042. Feel free to create PRs for your changes. |
This PR enables the use of the FMU (AUX) output for the multicopter motors on standard VTOL and tiltrotors.
The device path is needed to apply PWM limits on the motors that are not
used for FW flight (switch them off). With this parameter the device path can be set
to either IO or FMU, depending on whether the motors are on the IO or FMU port.