posix rcS: always disable CPU load check in SITL #14694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by this pull request
Multiple people reported that SITL wasn't arming anymore because the CPU load check was failing and that's because the parameter to disable the check in SITL is only set when the parameters are reset e.g. clean build.
Describe your solution
I set the parameter all the time now to prevent more people running into the problem.
Describe possible alternatives
SITL should also publish a CPU load but this is the hot fix.
Test data / coverage
I tested locally with an earlier configuration already built to reproduce the problem without the change and have it fixed with the change.
Additional context
#14570