matrix: pull explicit constructors #13088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one. I was also wondering if making most of Matrix explicit (if we can get away with it) might help catch other implicit conversions. Some of them are relatively expensive.
|
MaEtUgR
force-pushed
the
matrix-explicit-constructors
branch
from
a7c1c6f to
6e063a1
Compare
MaEtUgR
changed the title
|
Updates to matrix master since PX4/PX4-Matrix#99 was merged. |
dagar
approved these changes
Oct 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by the proposed pull request
Pulling in explicit array constructors PX4/PX4-Matrix#99 to reduce possibility for errors.
Test data / coverage
SITL flying.
Additional context
Only merge after PX4/PX4-Matrix#99 and updating to the matrix library hash on the
masterbranch.