-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move ekf2 and mc_pos_control to WQ #13060
Conversation
3e33618
to
484f4fc
Compare
@PX4/testflights could you please give this a quick flight on a multicopter with logs to compare with master? |
Tested on Pixhawk4 v5 f-450
Pr log: Master log: Tested on Pixracer v4 f-450
Pr log: Maste log: |
This saves nearly 7K of memory on a pixracer configured as a generic multicopter and from the logs I don't see any other issues. Let's try again with |
484f4fc
to
7a1aaf8
Compare
Thanks @dannyfpv. Could you repeat that same test again with the current state of the PR? Just the pixracer is fine. |
467bad3
to
a88afe4
Compare
Once this is merged it should be safe to lower CONFIG_MAX_TASKS again. |
- the primary data sources of the land detector run from the same WQ so don't lose anything by serializing these modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything wrong 👍.
Relative to current master this frees up about 8 KB of ram on px4_fmu-v4 (configured as generic multicopter). nsh> free
total used free largest
Umem: 230624 181744 48880 46160 <-- master
Umem: 231712 174848 56864 53440 <-- PR |
Opening this as an experiment to see if it's worthwhile moving both ekf2 and mc_pos_control to the same WQ. This is potentially worthwhile as it will save quite a lot of stack (6-7 KB), and a little bit of cpu (maybe 2-3% TBD).