-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable silent compare of parameter #12850
Conversation
A quieter init would be nice, but I also don't want to completely lose track of irrelevant cruft. Would it make sense to change the default to silent, but have some mechanism to enable the error output (build time or environment variable)? |
It also makes me wonder if we could do something more fundamental to capture a portion of the straightforward cases. Why don't we just generate that at build time if the module is part of that particular config? |
@dagar about the first comment, I think that the default shoud be non-silent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about having an argument --silent
? I think that would be more intuitive.
@julianoes I agree about --silent' but to '-s'. I will do the change later. |
The |
I think that the non-silent version should be the default. if we could we would have make it a build time error. But because we can't... only in cases we know we might "break" the rule of not trying to get a non-exist parameter we will use the silent compare. |
… versions: SYS_USE_IO, SENS_EN_PMW3901, CAM_CAP_FBACK
… versions: SYS_USE_IO, SENS_EN_PMW3901, CAM_CAP_FBACK
…-param_compare_silent
@julianoes Thanks! |
Describe problem solved by the proposed pull request
Remove false errors after comparing parameters that doesn't exists.
as described in #12832
Test data / coverage
This is draft, to look
Describe your preferred solution
new compare-silent, greater-silent commands. that should be used in cases that we know that there is possibility that the parameter doesn't exist at all.