Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable silent compare of parameter #12850

Merged
merged 9 commits into from
Oct 7, 2019

Conversation

BazookaJoe1900
Copy link
Member

Describe problem solved by the proposed pull request
Remove false errors after comparing parameters that doesn't exists.
as described in #12832

Test data / coverage
This is draft, to look

Describe your preferred solution
new compare-silent, greater-silent commands. that should be used in cases that we know that there is possibility that the parameter doesn't exist at all.

@dagar
Copy link
Member

dagar commented Sep 1, 2019

A quieter init would be nice, but I also don't want to completely lose track of irrelevant cruft. Would it make sense to change the default to silent, but have some mechanism to enable the error output (build time or environment variable)?

@dagar dagar requested review from bkueng and dagar September 1, 2019 14:14
@BazookaJoe1900
Copy link
Member Author

@dagar about the first comment, I think that the default shoud be non-silent
about generating RCs according to build, If you can show me how that can be done I can start to implement that

Copy link
Contributor

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about having an argument --silent? I think that would be more intuitive.

@BazookaJoe1900
Copy link
Member Author

BazookaJoe1900 commented Sep 3, 2019

@julianoes I agree about --silent' but to '-s'. I will do the change later.
BTW, I think that script should not even try to call parameter that doesn't exists. but current implementation doesn't fit to that.
I have contacted with @dagar about that and talked about some kind of manifest that will generate rcS parts according to spacific compilation modules. #12409

@dagar
Copy link
Member

dagar commented Oct 4, 2019

The -s seems fine, although I'm still wondering where we actually care about keeping the non-silent version.

@BazookaJoe1900
Copy link
Member Author

I think that the non-silent version should be the default. if we could we would have make it a build time error. But because we can't... only in cases we know we might "break" the rule of not trying to get a non-exist parameter we will use the silent compare.
I can think of a method that during build time I can give a warrning/error if a RC script try to fetch non-exist parameter

@dagar dagar marked this pull request as ready for review October 6, 2019 14:59
@BazookaJoe1900 BazookaJoe1900 deleted the pr-param_compare_silent branch October 6, 2019 16:47
@BazookaJoe1900 BazookaJoe1900 restored the pr-param_compare_silent branch October 6, 2019 17:09
@BazookaJoe1900 BazookaJoe1900 reopened this Oct 6, 2019
@julianoes julianoes changed the title enable silent compere of parameter enable silent compare of parameter Oct 7, 2019
@julianoes julianoes merged commit 02e861b into PX4:master Oct 7, 2019
@BazookaJoe1900 BazookaJoe1900 deleted the pr-param_compare_silent branch October 7, 2019 08:38
@BazookaJoe1900
Copy link
Member Author

@julianoes Thanks!
Now the real "test" is to verify that there are no Errors running the startup script. that is something that I know that @dagar working on.
You delete the branch on the PX4/Firmware/pr-param_compare_silent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants