logger move to uORB::SubscriptionInterval #12123

dagar · 2019-05-30T19:05:37Z

~~Requires a higher level design review and #12040 before merging.~~

dagar · 2019-06-05T00:30:42Z

@PX4/testflights could you give this an initial flight test?

jorge789 · 2019-06-05T21:33:35Z

Tested on Pixhawk 4 V5

Modes Tested

Position Mode: Good.
Altitude Mode: Good.
Stabilized Mode: Good.
Mission Plan Mode (Automated): Good.
RTL: Good.

- Procedure
Arm and Take off in position mode, after flying for approximately one minute, switched to altitude then stabilized mode proceed to switch to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoin activate RTL and see landing behaviour.

Notes:
No issues noted, good flight in general.

Logs:
https://review.px4.io/plot_app?log=8653da75-a92a-4c73-98ec-e274a611947c

https://review.px4.io/plot_app?log=dc323f18-7838-47ff-986a-2c43c3d6be60

Comparison to master
https://review.px4.io/plot_app?log=f3bf829a-b204-444e-be36-77dab0d1fcb9

dagar · 2019-06-06T00:49:48Z

@Tony3dr @jorge789 those logs seem to be from #12162. Can you try again with the current state of this PR? Thanks.

Tony3dr · 2019-06-06T15:29:50Z

@Tony3dr @jorge789 those logs seem to be from #12162. Can you try again with the current state of this PR? Thanks.

@dagar thanks for pointing that out, we will test the PR today.

jorge789 · 2019-06-06T22:05:27Z

Tested on Pixhawk 2 Cube V3:

Modes Tested

Position Mode: Good.
Altitude Mode: Good.
Stabilized Mode: Good.
Mission Plan Mode (Automated): Good.
RTL: Good.

- Procedure
Arm and Take off in position mode, after flying for approximately one minute, switched to altitude then stabilized mode proceed to switch to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoin activate RTL and see landing behaviour.

Notes:
No issues noted, good flight in general.
Logs
https://review.px4.io/plot_app?log=170541f1-b7d5-4825-85e3-69a723d88945

Comparison to master
https://review.px4.io/plot_app?log=b31999c2-52eb-40e0-a440-a9c510e05ab8

dannyfpv · 2019-06-06T22:47:46Z

Tested on Pixhawk 4 V5 f-450
Modes Tested

Position Mode: no issue
Altitude Mode: no issue
Stabilized Mode: no issue
Mission Plan Mode: : no issue
RTL: no issue

Notes:
No issues noted, good flight in general.

PR log:
https://review.px4.io/plot_app?log=ad5bf2db-4a36-4ab8-b253-23776d01e5e2

pr log 08/05/19 no issues:
https://review.px4.io/plot_app?log=a8da628f-165b-4c7b-812d-ca3115d12007

Master log:
https://review.px4.io/plot_app?log=0c295146-ffb9-4920-8821-bf2c3141ff15

dagar · 2019-06-07T00:44:24Z

Thanks for the early test. This still needs more work.

Junkim3DR · 2019-06-07T17:36:37Z

Tested on Pixhawk 4 mini v5

Modes Tested

Position Mode: Good.
Altitude Mode: Good.
Stabilized Mode: Good.
Mission Plan Mode (Automated): Good.
RTL: Good.

Procedure
Arm and Take off in position mode, after flying for approximately one minute, switched to altitude then stabilized mode proceed to switch to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoin activate RTL and see landing behaviour.

Notes:
No issues noted, good flight in general.

Logs:
PR 12123

https://review.px4.io/plot_app?log=a7185769-56ba-494f-b3df-78ed98464358

Master

https://review.px4.io/plot_app?log=e3db6d5c-dd0c-45da-99ce-8d2aaead010b

dagar · 2019-06-08T18:27:09Z

Ready for review and testing.

bkueng · 2019-08-05T09:02:18Z

Can you please separate the commits better? For example the _ulog_stream_pub change is independent from the rest.

dagar · 2019-08-05T19:37:40Z

@jorge789 those are the logs for #12224

jorge789 · 2019-08-05T20:18:11Z

@jorge789 those are the logs for #12224

Thanks for the observation, I got an error when I opened Jenkins and just proceeded to reload, that might have been the issue.

Junkim3DR · 2019-08-05T20:58:57Z

Tested on Pixhawk Pro v4

Modes Tested

Position Mode: Good.
Altitude Mode: Good.
Stabilized Mode: Good.
Mission Plan Mode (Automated): Good.
RTL: Good.

Procedure
Arm and Take off in position mode, after flying for approximately one minute, switched to altitude then stabilized mode proceed to switch to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoin activate RTL and see landing behaviour.

Notes:
No issues noted, good flight in general.

Logs:

https://review.px4.io/plot_app?log=43fb8dd7-9706-4837-bb29-06bc1006d1e8

Tested on Pixhawk 4 mini v5

Modes Tested

Position Mode: Good.
Altitude Mode: Good.
Stabilized Mode: Good.
Mission Plan Mode (Automated): Good.
RTL: Good.

Procedure
Arm and Take off in position mode, after flying for approximately one minute, switched to altitude then stabilized mode proceed to switch to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoin activate RTL and see landing behaviour.

Notes:
No issues noted, good flight in general.

Logs:

https://review.px4.io/plot_app?log=53012b02-5683-4551-9718-2cd235c5ecb1

Tested on NXP FMUK66 v3

Modes Tested

Position Mode: Good.
Altitude Mode: Good.
Stabilized Mode: Good.
Mission Plan Mode (Automated): Good.
RTL: Good.

Procedure
Arm and Take off in position mode, after flying for approximately one minute, switched to altitude then stabilized mode proceed to switch to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoin activate RTL and see landing behaviour.

Notes:
No issues noted, good flight in general.

Logs:

https://review.px4.io/plot_app?log=47d26960-bddf-41a9-92e0-926023ab6e74

dagar · 2019-08-06T05:52:35Z

Can you please separate the commits better? For example the _ulog_stream_pub change is independent from the rest.

I can bring that in separately if it helps.

bkueng · 2019-08-06T07:44:31Z

Separate commits is enough.

dagar · 2019-08-06T15:17:03Z

Rebased on master with the other pieces merged.

bkueng

One detail, otherwise good to merge.

src/modules/logger/logger.cpp

src/modules/logger/logger.h

src/modules/logger/logger.cpp

With #12123 all multi-instance topics lead to repeated format definitions in the ULog file.

With PX4#12123 all multi-instance topics lead to repeated format definitions in the ULog file.

dagar added the Admin: Enhancement (improvement) 💡 label May 30, 2019

dagar added this to the Release v1.10.0 milestone May 30, 2019

weekly-digest bot mentioned this pull request Jun 2, 2019

Weekly Digest (26 May, 2019 - 2 June, 2019) #12143

Closed

dagar mentioned this pull request Jun 3, 2019

uORB remove unused SubscriptionInterval and SubscriptionIntervalData #12160

Merged

dagar force-pushed the pr-logger_subscription branch 4 times, most recently from 54865eb to a0183c2 Compare June 5, 2019 00:27

dagar mentioned this pull request Jun 6, 2019

navigator move to new uORB::Subscription #12162

Merged

dagar force-pushed the pr-logger_subscription branch from a0183c2 to 0f3a4c6 Compare June 6, 2019 00:49

dagar force-pushed the pr-logger_subscription branch from 0f3a4c6 to d7e74a2 Compare June 6, 2019 01:19

dagar mentioned this pull request Jun 6, 2019

High RAM usage on Pixhawk 2.1 Cube #12203

Closed

dagar force-pushed the pr-logger_subscription branch from d7e74a2 to 5d29ab0 Compare June 7, 2019 18:59

dagar force-pushed the pr-logger_subscription branch 3 times, most recently from 8065959 to 85a9575 Compare June 8, 2019 17:45

dagar marked this pull request as ready for review June 8, 2019 18:27

dagar changed the title ~~[WIP] logger move to new uORB::Subscription~~ logger move to new uORB::Subscription Jun 8, 2019

dagar force-pushed the pr-logger_subscription branch from 85a9575 to 7928d6c Compare June 8, 2019 19:07

dagar force-pushed the pr-logger_subscription branch from 4f9d5a1 to 8813430 Compare August 6, 2019 05:43

This was referenced Aug 6, 2019

logger move non-logged subscriptions to uORB::Subscription #12639

Merged

uORB::Subscription minor API cleanup #12640

Merged

dagar force-pushed the pr-logger_subscription branch from 8813430 to 9d3b839 Compare August 6, 2019 15:13

dagar mentioned this pull request Aug 6, 2019

NuttX boards reduce CONFIG_NFILE_DESCRIPTORS 54 -> 20 #12646

Merged

logger move to new uORB::SubscriptionInterval

f632bbc

dagar force-pushed the pr-logger_subscription branch from 9d3b839 to f632bbc Compare August 7, 2019 02:21

bkueng reviewed Aug 7, 2019

View reviewed changes

src/modules/logger/logger.cpp Outdated Show resolved Hide resolved

julianoes reviewed Aug 7, 2019

View reviewed changes

src/modules/logger/logger.h Show resolved Hide resolved

dagar commented Aug 7, 2019

View reviewed changes

src/modules/logger/logger.cpp Outdated Show resolved Hide resolved

Update src/modules/logger/logger.cpp

ab2a674

dagar merged commit 83e532d into PX4:master Aug 7, 2019

dagar deleted the pr-logger_subscription branch August 7, 2019 15:02

weekly-digest bot mentioned this pull request Aug 11, 2019

Weekly Digest (4 August, 2019 - 11 August, 2019) #12682

Closed

bkueng added a commit that referenced this pull request Aug 21, 2019

logger: fix multiple format definitions for multi-instance topics

9bc3cfe

With #12123 all multi-instance topics lead to repeated format definitions in the ULog file.

bkueng mentioned this pull request Aug 21, 2019

logger: fix multiple format definitions for multi-instance topics #12764

Merged

dagar pushed a commit that referenced this pull request Aug 21, 2019

logger: fix multiple format definitions for multi-instance topics

7f6a9e5

With #12123 all multi-instance topics lead to repeated format definitions in the ULog file.

bozkurthan pushed a commit to bozkurthan/Firmware that referenced this pull request Sep 4, 2019

logger move to uORB::SubscriptionInterval (PX4#12123)

3a65764

bozkurthan pushed a commit to bozkurthan/Firmware that referenced this pull request Sep 4, 2019

logger: fix multiple format definitions for multi-instance topics

2f2c919

With PX4#12123 all multi-instance topics lead to repeated format definitions in the ULog file.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

logger move to uORB::SubscriptionInterval #12123

logger move to uORB::SubscriptionInterval #12123

dagar commented May 30, 2019 •

edited

Loading

dagar commented Jun 5, 2019

jorge789 commented Jun 5, 2019

dagar commented Jun 6, 2019

Tony3dr commented Jun 6, 2019

jorge789 commented Jun 6, 2019

dannyfpv commented Jun 6, 2019 •

edited

Loading

dagar commented Jun 7, 2019

Junkim3DR commented Jun 7, 2019 •

edited

Loading

dagar commented Jun 8, 2019

bkueng commented Aug 5, 2019

dagar commented Aug 5, 2019

jorge789 commented Aug 5, 2019

Junkim3DR commented Aug 5, 2019

dagar commented Aug 6, 2019

bkueng commented Aug 6, 2019

dagar commented Aug 6, 2019

bkueng left a comment

logger move to uORB::SubscriptionInterval #12123

logger move to uORB::SubscriptionInterval #12123

Conversation

dagar commented May 30, 2019 • edited Loading

dagar commented Jun 5, 2019

jorge789 commented Jun 5, 2019

Tested on Pixhawk 4 V5

dagar commented Jun 6, 2019

Tony3dr commented Jun 6, 2019

jorge789 commented Jun 6, 2019

Tested on Pixhawk 2 Cube V3:

dannyfpv commented Jun 6, 2019 • edited Loading

dagar commented Jun 7, 2019

Junkim3DR commented Jun 7, 2019 • edited Loading

Tested on Pixhawk 4 mini v5

dagar commented Jun 8, 2019

bkueng commented Aug 5, 2019

dagar commented Aug 5, 2019

jorge789 commented Aug 5, 2019

Junkim3DR commented Aug 5, 2019

Tested on Pixhawk Pro v4

Tested on Pixhawk 4 mini v5

Tested on NXP FMUK66 v3

dagar commented Aug 6, 2019

bkueng commented Aug 6, 2019

dagar commented Aug 6, 2019

bkueng left a comment

Choose a reason for hiding this comment

dagar commented May 30, 2019 •

edited

Loading

dannyfpv commented Jun 6, 2019 •

edited

Loading

Junkim3DR commented Jun 7, 2019 •

edited

Loading