Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmu-v5 config split #11406

Closed
wants to merge 2 commits into from
Closed

fmu-v5 config split #11406

wants to merge 2 commits into from

Conversation

simonegu
Copy link
Contributor

@simonegu simonegu commented Feb 7, 2019

Describe problem solved by the proposed pull request
It is not simple to read through the board_config file. This will separate the gpio configuration according to the fmu-v5 spec https://docs.google.com/spreadsheets/d/1-n0__BYDedQrc_2NHqBenG1DNepAgnHpSGglke-QQwY/edit?usp=sharing

Describe your preferred solution
Ported the gpio and bus specific configuration in a separate common file gpio_config.h between different revision. RC00 / RC01

Possible additional improvements
It would even better if we would get rid of the RC00 version specific config and the BOARD_HAS_LTC4417, thoughts?

Test
Bench tested on a fmu-v5

@simonegu simonegu requested a review from davids5 February 7, 2019 10:58
@dagar
Copy link
Member

dagar commented Feb 7, 2019

Did PX4_FMUV5_RC00 ever ship in a product? If not I think we should drop it.

@dagar
Copy link
Member

dagar commented Feb 7, 2019

Can we review and merge this one first? #11370

@dagar
Copy link
Member

dagar commented Feb 7, 2019

If there's interest in breaking up this file why not do it by function?

adc/power
spi
can
timers

@simonegu
Copy link
Contributor Author

simonegu commented Feb 7, 2019

Can we review and merge this one first? #11370

👍

If there's interest in breaking up this file why not do it by function?

@dagar I thought about that but since it is really specific to each board I thought that it could become a little cumbersome in the future maintenance if we split in 4 or more files for each board.

@davids5
Copy link
Member

davids5 commented Feb 7, 2019

@simonegu, @dagar here we we should only remove the dead code for PX4_FMUV5_RC00

But leave I would the BOARD_HAS_LTC4417 - or you will have to document how to build a non LTC4417 design.

//#define PX4_FMUV5_RC00

#define PX4_FMUV5_RC01
#define BOARD_HAS_LTC4417

@davids5 davids5 closed this Feb 7, 2019
@simonegu simonegu deleted the pr-fmu-v5-config-split branch February 7, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants