Fix bugs in Calculator.reform_documentation function #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1596 +/- ##
======================================
Coverage 100% 100%
======================================
Files 37 37
Lines 2739 2743 +4
======================================
+ Hits 2739 2743 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bugs when policy parameter is a boolean scalar (like the
_EITC_indivparameter).These bugs were encountered when using
tcin pull request #1595. Using in a reeform the new boolean scalar parameter introduced in #1595,_CTC_new_for_all, revealed the bugs and the less than complete unit test. The test was strengthened (so that it triggers the boolean scalar bugs) and then the code was fixed.