Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add a bad error msg to track list #2876

Merged
merged 3 commits into from
Jun 21, 2023
Merged

test: Add a bad error msg to track list #2876

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
446e2b7
Add a bad error msg to track list
khoa165 Jun 20, 2023
203a936
NIT: update comment
khoa165 Jun 21, 2023
3de6973
Merge branch 'main' into track-bad-err-msg
khoa165 Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions prql-compiler/src/tests/test_bad_error_messages.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,20 @@ fn test_bad_error_messages() {
│ Note: Type `relation` expands to `[tuple_of_scalars]`
───╯
"###);

// It's better if we can tell them to put in {} braces
assert_display_snapshot!(compile(r###"
from artists
sort -name
"###).unwrap_err(), @r###"
Error:
╭─[:3:11]
│
3 │ sort -name
│ ──┬─
│ ╰─── Unknown name
───╯
"###);
}

#[test]
Expand Down