Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add a bad error msg to track list #2876

Merged
merged 3 commits into from
Jun 21, 2023
Merged

test: Add a bad error msg to track list #2876

merged 3 commits into from
Jun 21, 2023

Conversation

khoa165
Copy link
Contributor

@khoa165 khoa165 commented Jun 20, 2023

Changes

  • Add a test for a bad error message when query sort decreasing order but without square bracket

Type

  • Dev

Issue

#2282

@khoa165 khoa165 changed the title Add a bad error msg to track list [test] Add a bad error msg to track list Jun 20, 2023
@khoa165 khoa165 changed the title [test] Add a bad error msg to track list test: Add a bad error msg to track list Jun 20, 2023
max-sixty
max-sixty approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect first PR. Great example of a terrible error message...

prql-compiler/src/tests/test_bad_error_messages.rs Outdated Show resolved Hide resolved
@max-sixty max-sixty merged commit 66fd004 into PRQL:main Jun 21, 2023
@khoa165 khoa165 deleted the track-bad-err-msg branch June 21, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khoa165 @max-sixty