Show when the feedback has been published

Note the mechanism used has accessibility issues that must be addressed before the feature flag is removed. Refs #1941, alphagov/govuk-design-system-backlog#28 (comment)
PREreview · Sep 27, 2024 · 4d47598 · 4d47598
1 parent bbf078e
commit 4d47598
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 3 deletions.
diff --git a/integration/writing-feedback.spec.ts b/integration/writing-feedback.spec.ts
@@ -92,9 +92,6 @@ test.extend(canLogIn).extend(areLoggedIn).extend(canWriteFeedback).extend(willPu
 
     await expect(page.getByRole('heading', { level: 1 })).toHaveText('We’re publishing your feedback')
 
-    await page.waitForTimeout(500)
-    await page.reload()
-
     await expect(page.getByRole('heading', { level: 1 })).toHaveText('Feedback published')
   },
 )

diff --git a/src/WriteFeedbackFlow/PublishingPage/PublishingPage.ts b/src/WriteFeedbackFlow/PublishingPage/PublishingPage.ts
@@ -6,6 +6,7 @@ import type { Uuid } from '../../types/index.js'
 export const PublishingPage = ({ feedbackId }: { feedbackId: Uuid.Uuid }) =>
   StreamlinePageResponse({
     title: plainText`We’re publishing your feedback`,
+    head: html`<meta http-equiv="refresh" content="2" />`,
     main: html`
       <h1>We’re publishing your feedback</h1>
 

diff --git a/src/page.ts b/src/page.ts
@@ -46,6 +46,7 @@ export interface Page {
   readonly locale?: SupportedLocale
   readonly title: PlainText
   readonly description?: PlainText
+  readonly head?: Html
   readonly type?: 'two-up' | 'streamline'
   readonly content: Html
   readonly skipLinks?: ReadonlyArray<[Html, string]>
@@ -82,6 +83,7 @@ export function page({
   locale = DefaultLocale,
   title,
   description,
+  head,
   type,
   content,
   skipLinks = [],
@@ -131,6 +133,7 @@ export function page({
             : ''}
           <link rel="icon" href="${assets['favicon.ico']}" sizes="32x32" />
           <link rel="icon" href="${assets['favicon.svg']}" type="image/svg+xml" />
+          ${head ?? ''}
         </head>
         <body ${rawHtml(type === 'two-up' ? `class="${type}"` : '')}>
           ${skipLinks.length > 0

diff --git a/src/response.ts b/src/response.ts
@@ -51,6 +51,7 @@ export interface StreamlinePageResponse {
   readonly status: Status
   readonly title: Page['title']
   readonly description?: Page['description']
+  readonly head?: Html
   readonly nav?: Html
   readonly main: Html
   readonly skipToLabel: 'form' | 'main'
@@ -202,6 +203,7 @@ export const toPage = ({
         locale: locale !== DefaultLocale ? locale : undefined,
         title: response.title,
         description: response.description,
+        head: response._tag === 'StreamlinePageResponse' ? response.head : undefined,
         content: html`
           ${response.nav ? html` <nav>${response.nav}</nav>` : ''}
 

diff --git a/test/WriteFeedbackFlow/PublishingPage.test.ts b/test/WriteFeedbackFlow/PublishingPage.test.ts
@@ -25,6 +25,7 @@ describe('PublishingPage', () => {
           canonical: Routes.WriteFeedbackPublishing.href({ feedbackId }),
           status: StatusCodes.OK,
           title: expect.stringContaining('publishing'),
+          head: expect.stringContaining('refresh'),
           main: expect.stringContaining('publishing'),
           skipToLabel: 'main',
           js: [],