Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the discussion with @niosus in #421, it turned out that we can make the deskewing a bit easier to understand by using the original transformation from the
mid_pose_timestamp
solution, but with a fixed reference timestamp of1.0
. The motivation behind setting it to1.0
can be found in the PR reference above.This is mainly a cosmetic change, but it is more readable because we deskew and represent the scan at the end of the scan duration (in contrast to the current main, where we deskew to the beginning of the scan and then represent it at the end pose).
I checked the first 1000 scans of Riverside01, and we obtain the same results, and it's minimally faster (single thread for proper runtime comparison):
Main:
This PR: