Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stop many #200

Merged
merged 5 commits into from
Jan 16, 2022
Merged

feat: stop many #200

merged 5 commits into from
Jan 16, 2022

Conversation

gamaraan
Copy link
Contributor

  • add stopMany command
  • update documentation to include stopMany
  • add stopMany test

@AlexZeitler
Copy link
Contributor

@gamaraan Looks like this PR includes the rm fix you mentioned here #199 (comment) ?

@gamaraan
Copy link
Contributor Author

@gamaraan Looks like this PR includes the rm fix you mentioned here #199 (comment) ?

No, I've found out that compose.rm is actually working fine for multiple containers also, so I've reverted the fix. I was passing the wrong arguments.

let services = ['web','proxy']
compose.rm(options,services) //fails
compose.rm(options,...services) //works

@gamaraan
Copy link
Contributor Author

Sorry for another push, needed to pass lint tests

@AlexZeitler AlexZeitler merged commit f10a9b6 into PDMLab:master Jan 16, 2022
@AlexZeitler
Copy link
Contributor

@gamaraan thanks 👍 📦 @ 0.23.16 is now available on npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants