Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: docker-compose rm command when passing multiple services #199

Closed
wants to merge 2 commits into from
Closed

fix: docker-compose rm command when passing multiple services #199

wants to merge 2 commits into from

Conversation

gamaraan
Copy link
Contributor

  • fix rm command when passing as argument multiple services
  • add stopMany command
  • update documentation

AlexZeitler
AlexZeitler requested changes Jan 15, 2022
View reviewed changes
Copy link
Contributor

@AlexZeitler AlexZeitler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a test for stopMany?

@gamaraan gamaraan closed this Jan 15, 2022
@gamaraan gamaraan deleted the fix-docker-compose-rm branch January 15, 2022 21:01
@gamaraan
Copy link
Contributor Author

gamaraan commented Jan 15, 2022 •
edited
Loading

Ignore the previously proposed compose.rm fix, I was actually passing wrong arguments to it.
I've made a new PR for stopMany function only, with tests included.

@AlexZeitler AlexZeitler mentioned this pull request Jan 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexZeitler AlexZeitler AlexZeitler requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gamaraan @AlexZeitler