Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable option to build share lib in CMakeLists.txt #48

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

MDuc-ai
Copy link
Contributor

@MDuc-ai MDuc-ai commented Oct 22, 2024

Add option(BUILD_SHARED_LIBS "build shared libraries" OFF) and remove the STATIC out from add_library() to allow higher-level CMakeLists.txt to build share library

@MDuc-ai
Copy link
Contributor Author

MDuc-ai commented Oct 22, 2024

Btw, I'm developing Python bindings for bark.cpp, and you can find the project here: bark-cpp-python . I'd really appreciate any support or contributions to help improve the package and make it even better!"

@PABannier
Copy link
Owner

PABannier commented Oct 22, 2024

This is very helpful @tranminhduc4796 ! Thanks for this work. Indeed, this would be very convenient to have python bindings. Once built, I can reference them to the README of the repo :)

@PABannier PABannier merged commit 2cf7411 into PABannier:main Oct 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants