Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable option to build .so files for Python binding with Ctypes #47

Closed
MDuc-ai opened this issue Oct 22, 2024 · 4 comments
Closed

Enable option to build .so files for Python binding with Ctypes #47

MDuc-ai opened this issue Oct 22, 2024 · 4 comments

Comments

@MDuc-ai
Copy link
Contributor

MDuc-ai commented Oct 22, 2024

I am writing Python binding for bark.cpp and due to the specific add_library(${ENCODEC_LIB} STATIC encodec.cpp encodec.h), I could not use a high-level CmakeLists.txt to build the .so file for encodec.cpp. We should add option to build share library:

option(BUILD_SHARED_LIBS "build shared libraries" OFF) add_library(${ENCODEC_LIB} encodec.cpp encodec.h)
This should be applied on the bark.cpp as well

@MDuc-ai
Copy link
Contributor Author

MDuc-ai commented Oct 22, 2024

I created a PR #48 for this issue. Would you mind taking a look when you have a chance? It'll help us get the Python bindings for bark.cpp ready.

@PABannier
Copy link
Owner

PABannier commented Oct 22, 2024

Thank you very much @tranminhduc4796 . Just merged #48 . Does that fix the issue? If so, feel free to close it.

@MDuc-ai
Copy link
Contributor Author

MDuc-ai commented Oct 23, 2024

Actually, I still need to wait for the success PR of bark.cpp syncing up with the latest encoded PABannier/bark.cpp#199 to be able to apply this PR. But anyway, thank you for your great support. I will close this issue.

@MDuc-ai MDuc-ai closed this as completed Oct 23, 2024
@PABannier
Copy link
Owner

Well-noted, I'll try to finish it this week-end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants