Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Frustum Culling by default #350

Merged
merged 3 commits into from
Feb 8, 2025
Merged

Enable Frustum Culling by default #350

merged 3 commits into from
Feb 8, 2025

Conversation

sameep-git
Copy link
Contributor

Closes: #345

  1. Change EditorSettings.h properties which affect Frustum Culling from false to true.

@sameep-git
enabled frustum culling everywhere
548a302 
Signed-off-by: sameep-git <sameep.shah@tcu.edu>
adriengivry
adriengivry requested changes Feb 8, 2025
View reviewed changes
Copy link
Member

@adriengivry adriengivry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Would be nice if the in-game camera also had frustum culling enabled by default. This could be done by modifying the default values here:

https://github.com/adriengivry/Overload/blob/develop/Sources/Overload/OvRendering/src/OvRendering/Entities/Camera.cpp

@sameep-git
enabled frustum culling by default for in-game camera
71cd3d5 
Signed-off-by: sameep-git <sameep.shah@tcu.edu>
@sameep-git
Copy link
Contributor Author

Looks good to me! Would be nice if the in-game camera also had frustum culling enabled by default. This could be done by modifying the default values here:

https://github.com/adriengivry/Overload/blob/develop/Sources/Overload/OvRendering/src/OvRendering/Entities/Camera.cpp

Does 71cd3d5 fix it?

adriengivry
adriengivry requested changes Feb 8, 2025
View reviewed changes
Copy link
Member

@adriengivry adriengivry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to update DebugFrustumCulling to set it back to false by default, otherwise I tested it and it works as expected!

@sameep-git
change DebugFrustumCulling back to false
fe09dd7 
Signed-off-by: sameep-git <sameep.shah@tcu.edu>
adriengivry
adriengivry approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@adriengivry adriengivry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adriengivry adriengivry added QoL Quality of Life : Something that can improve users productivity Editor Something relative with the editor Graphics Graphical feature labels Feb 8, 2025
@adriengivry adriengivry merged commit 8892ec5 into Overload-Technologies:develop Feb 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriengivry adriengivry adriengivry approved these changes

Assignees

@sameep-git sameep-git

Labels
Editor Something relative with the editor Graphics Graphical feature QoL Quality of Life : Something that can improve users productivity
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable frustum culling by default everywhere
2 participants
@sameep-git @adriengivry