Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable frustum culling by default everywhere #345

Closed
adriengivry opened this issue Feb 7, 2025 · 3 comments · Fixed by #350
Closed

Enable frustum culling by default everywhere #345

adriengivry opened this issue Feb 7, 2025 · 3 comments · Fixed by #350
Labels
Feature New feature to the engine Good First Issue An easy issue for new contributors QoL Quality of Life : Something that can improve users productivity

Comments

@adriengivry
Copy link
Member

Problem this feature should fix
Editor and in-game frustum culling is disabled by default. I believe it should be ON everywhere!

Expected solution
Enable frustum culling everywhere
@adriengivry adriengivry added Feature New feature to the engine QoL Quality of Life : Something that can improve users productivity Good First Issue An easy issue for new contributors labels Feb 7, 2025
@sameep-git
Copy link
Contributor

Hi, I would like to help with this issue. I am new to Overload and open source. I looked around the code base and found this file. Will the change be reflected by changing these values to true?
https://github.com/adriengivry/Overload/blob/7e74b39bb346a6e02d3ff449141309acd0f4ff87/Sources/Overload/OvEditor/include/OvEditor/Settings/EditorSettings.h#L78-L80

I was not able to find any in-game settings which would affect default behavior in my quick search. Would these changes only affect the editor or would they affect in-game too?

@adriengivry
Copy link
Member Author

I think so! Setting these to true should address the issue!

@sameep-git
Copy link
Contributor

I think so! Setting these to true should address the issue!

Great! I will start working on it.

@sameep-git sameep-git mentioned this issue Feb 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature New feature to the engine Good First Issue An easy issue for new contributors QoL Quality of Life : Something that can improve users productivity
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable Frustum Culling by default sameep-git/Overload
2 participants
@adriengivry @sameep-git