Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMET-3608 FB Crashlytics - Update dependency to Firebase Crashlytics Android SDK #31

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

alexgerardojacinto
Copy link
Collaborator

@alexgerardojacinto alexgerardojacinto commented Sep 12, 2024

Description

  • This PR updates the dependency to the Firebase Crashlytics Android SDK to the latest version, using the Firebase Android BoM dependency.
  • As such, the dependency was moved from the plugin.xml to the build.gradle file, following best practices, as this way we have more control on how dependencies are included in the app.

Context

References: https://outsystemsrd.atlassian.net/browse/RMET-3608

Type of changes

  • Fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Refactor (cosmetic changes)
  • Breaking change (change that would cause existing functionality to not work as expected)

Platforms affected

  • Android
  • iOS
  • JavaScript

Tests

Tested on MABS 10 build, on Android 15 (Pixel 7) and Android 12 (Pixel 3XL)

MABS 10 build: https://intranet.outsystems.net/MABS/BuildDetail.aspx?BuildId=3bbc9b27f095fcd3f41618defe8e1af9e5215cbf

Nativizer build with all supported plugins (including Firebase plugins + OneSignal): https://intranet.outsystems.net/MABS/BuildDetail.aspx?BuildId=41229af81be7c243397b3c20cb8fd5d5364dbd85

Screenshots (if appropriate)

Checklist

  • Pull request title follows the format RNMT-XXXX <title>
  • Code follows code style of this project
  • CHANGELOG.md file is correctly updated
  • Changes require an update to the documentation
    • Documentation has been updated accordingly

… Crashlytics

Context: According to the documentation, this is the recommended way of controlling Firebase library versions. This way, using the Firebase Android BOM, an app with multiple Firebase Android libraries will always use compatible versions of these libraries.

References: https://outsystemsrd.atlassian.net/browse/RMET-3608
@alexgerardojacinto alexgerardojacinto changed the title Feat/rmet 3608/update firebase sdk RMET-3608 FB Crashlytics - Update dependency to Firebase Crashlytics Android SDK Sep 13, 2024
@alexgerardojacinto alexgerardojacinto self-assigned this Sep 13, 2024
@alexgerardojacinto alexgerardojacinto marked this pull request as ready for review September 13, 2024 10:37
@alexgerardojacinto alexgerardojacinto requested a review from a team as a code owner September 13, 2024 10:37
@alexgerardojacinto alexgerardojacinto merged commit 8f2f197 into development Sep 13, 2024
1 check passed
alexgerardojacinto added a commit that referenced this pull request Sep 17, 2024
* chore: Raise Pod Version (#26)

Raises Pod version to 8.15.0

References: https://outsystemsrd.atlassian.net/browse/RMET-3143

* RMET-3274 ::: iOS ::: Update 3rd Party that Adds Privacy Manifest (#28)

* chore: Update iOS SDK version

Update iOS' 3rd party SDK version to `10.23.0`.
Enable the `use_frameworks` flag for CocoaPods.
Fix import errors.

References: https://outsystemsrd.atlassian.net/browse/RMET-3274

* chore: Add CHANGELOG entry

References: https://outsystemsrd.atlassian.net/browse/RMET-3274

* chore: Set Release Version (#29)

Prepare release of `3.0.0-OS10`.
Clean `CHANGELOG`.

References: https://outsystemsrd.atlassian.net/browse/RMET-3341

* RMET-3608 FB Crashlytics - Update dependency to Firebase Crashlytics Android SDK (#31)

* feat: feat: use Firebase Android BOM library to set the version of FB Crashlytics

Context: According to the documentation, this is the recommended way of controlling Firebase library versions. This way, using the Firebase Android BOM, an app with multiple Firebase Android libraries will always use compatible versions of these libraries.

References: https://outsystemsrd.atlassian.net/browse/RMET-3608

* fix: declare Firebase dependencies in build.gradle file

References: https://outsystemsrd.atlassian.net/browse/RMET-3608

* refactor: remove unnecessary Cordova preference

References: https://outsystemsrd.atlassian.net/browse/RMET-3608

* chore: update changelog

References: https://outsystemsrd.atlassian.net/browse/RMET-3608

* chore(release): raise to version 3.0.0-OS11

References: https://outsystemsrd.atlassian.net/browse/RMET-3608

---------

Co-authored-by: Ricardo Silva <97543217+OS-ricardomoreirasilva@users.noreply.github.com>
Co-authored-by: OS-ricardomoreirasilva <ricardo.moreira.silva@outsystems.com>
@alexgerardojacinto alexgerardojacinto deleted the feat/RMET-3608/update-firebase-sdk branch September 17, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants