Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RMET-3608 FB Crashlytics - Update dependency to Firebase Crashlytics Android SDK #31

Merged
merged 4 commits into from
Sep 13, 2024
Merged

RMET-3608 FB Crashlytics - Update dependency to Firebase Crashlytics Android SDK #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1860ca6
feat: feat: use Firebase Android BOM library to set the version of FB…
alexgerardojacinto Sep 11, 2024
88a2b8a
fix: declare Firebase dependencies in build.gradle file
alexgerardojacinto Sep 11, 2024
4b1f999
refactor: remove unnecessary Cordova preference
alexgerardojacinto Sep 11, 2024
0bb2aa9
chore: update changelog
alexgerardojacinto Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

The changes documented here do not include those from the original repository.

## Unreleased

- Feat: Android | Update dependency to Firebase Crashlytics Android library (https://outsystemsrd.atlassian.net/browse/RMET-3608).

## 3.0.0-OS10

- Chore: Update `FirebaseCrashlytics` iOS pod to version `10.23.0`. This includes the Privacy Manifest (https://outsystemsrd.atlassian.net/browse/RMET-3274).
Expand Down
2 changes: 0 additions & 2 deletions plugin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ xmlns:android="http://schemas.android.com/apk/res/android"
</platform>

<platform name="android">
<preference name="ANDROID_FIREBASE_CRASHLYTICS_VERSION" default="18.2.13"/>

<hook type="before_plugin_install" src="hooks/android/build_gradle_add_dependency.js" />

Expand All @@ -83,7 +82,6 @@ xmlns:android="http://schemas.android.com/apk/res/android"

<dependency id="cordova-support-android-plugin" version="~1.0.0"/>

<framework src="com.google.firebase:firebase-crashlytics:$ANDROID_FIREBASE_CRASHLYTICS_VERSION" />
<framework src="src/android/build.gradle" custom="true" type="gradleReference" />
</platform>

Expand Down
5 changes: 5 additions & 0 deletions src/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ android {
}
}

dependencies {
implementation platform('com.google.firebase:firebase-bom:33.2.0')
implementation("com.google.firebase:firebase-crashlytics")
}

// use postBuildExtras to make sure the plugin is applied after
// cdvPluginPostBuildExtras. Therefore if googleServices is added
// to cdvPluginPostBuildExtras somewhere else, the plugin execution
Expand Down