RMET-2252 :: Remove JSON file dependency , add Endpoint #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OS-martacarlos
requested review from
felipecn,
alexgerardojacinto,
hectorjdgdev and
OS-ricardomoreirasilva
alexgerardojacinto
approved these changes
Feb 16, 2023
OS-ricardomoreirasilva
approved these changes
Feb 16, 2023
OS-ricardomoreirasilva
added a commit
that referenced
this pull request
Mar 21, 2023
* chore: Add Unreleased Tag to CHANGELOG * fix: Optional Apple SignIn (#36) Apply fix on hook that checks if Apple SignIn should be included on the plugin or not. This is done by changing the Debug and Release Entitlements files. * RMET-2252 :: Remove JSON file dependency , add Endpoint (#38) * feat: add endpoint logic to android hook * fix: add config parser import * removing fetch + add axios * minor typo fix * feat: add get endpoint to iOS * remove static dependency * adding more error handling * chore: refactor * refactor: rename preference to be more accurate * reactor: change preference according to Dev Exp suggestion * fix: change error accordingly * feat: iOS | Update Error Codes (#40) Update error codes. Update library to use new error descriptions. Delete console logs from hook. * RMET-2343 Social Logins Plugin - Update error codes (#39) * feat: format error codes References: https://outsystemsrd.atlassian.net/browse/RMET-2343 * chore: update changelog * fix: fixing typo on error message --------- Co-authored-by: Marta Carlos <marta.carlos@outsystems.com> * chore: Set Release Tag Set Release Tag and update Android and iOS libraries to the latest ones. --------- Co-authored-by: Marta Carlos <101343976+OS-martacarlos@users.noreply.github.com> Co-authored-by: Alexandre Jacinto <alexandre.jacinto@outsystems.com> Co-authored-by: Marta Carlos <marta.carlos@outsystems.com>
nflsilva
added a commit
that referenced
this pull request
Oct 24, 2023
* chore: Add Unreleased Tag to CHANGELOG * fix: Optional Apple SignIn (#36) Apply fix on hook that checks if Apple SignIn should be included on the plugin or not. This is done by changing the Debug and Release Entitlements files. * RMET-2252 :: Remove JSON file dependency , add Endpoint (#38) * feat: add endpoint logic to android hook * fix: add config parser import * removing fetch + add axios * minor typo fix * feat: add get endpoint to iOS * remove static dependency * adding more error handling * chore: refactor * refactor: rename preference to be more accurate * reactor: change preference according to Dev Exp suggestion * fix: change error accordingly * feat: iOS | Update Error Codes (#40) Update error codes. Update library to use new error descriptions. Delete console logs from hook. * RMET-2343 Social Logins Plugin - Update error codes (#39) * feat: format error codes References: https://outsystemsrd.atlassian.net/browse/RMET-2343 * chore: update changelog * fix: fixing typo on error message --------- Co-authored-by: Marta Carlos <marta.carlos@outsystems.com> * chore: Set Release Tag Set Release Tag and update Android and iOS libraries to the latest ones. * RMET-2844 ::: Android ::: Facebook fix for MABS 10 (#43) * fix: updated facebook-android-sdk version for MABS10 bug. * fix: added sociallogins lib 1.1.1-r1 * chore: updated changelog * chore: bumped version to 1.1.2 --------- Co-authored-by: OS-ricardomoreirasilva <ricardo.moreira.silva@outsystems.com> Co-authored-by: Ricardo Silva <97543217+OS-ricardomoreirasilva@users.noreply.github.com> Co-authored-by: Marta Carlos <101343976+OS-martacarlos@users.noreply.github.com> Co-authored-by: Alexandre Jacinto <alexandre.jacinto@outsystems.com> Co-authored-by: Marta Carlos <marta.carlos@outsystems.com>
OS-martacarlos
added a commit
that referenced
this pull request
Jan 23, 2024
* feat: add endpoint logic to android hook * fix: add config parser import * removing fetch + add axios * minor typo fix * feat: add get endpoint to iOS * remove static dependency * adding more error handling * chore: refactor * refactor: rename preference to be more accurate * reactor: change preference according to Dev Exp suggestion * fix: change error accordingly
OS-martacarlos
added a commit
that referenced
this pull request
Jan 23, 2024
* chore: Add Unreleased Tag to CHANGELOG * fix: Optional Apple SignIn (#36) * Apply fix on hook that checks if Apple SignIn should be included on the plugin or not. This is done by changing the Debug and Release Entitlements files. * RMET-2252 :: Remove JSON file dependency , add Endpoint (#38) * feat: add endpoint logic to android hook * fix: add config parser import * removing fetch + add axios * minor typo fix * feat: add get endpoint to iOS * remove static dependency * adding more error handling * chore: refactor * refactor: rename preference to be more accurate * reactor: change preference according to Dev Exp suggestion * fix: change error accordingly * feat: iOS | Update Error Codes (#40) * Update error codes. * Update library to use new error descriptions. * Delete console logs from hook. * RMET-2343 Social Logins Plugin - Update error codes (#39) * feat: format error codes References: https://outsystemsrd.atlassian.net/browse/RMET-2343 * chore: update changelog * fix: fixing typo on error message * chore: Set Release Tag * Set Release Tag and update Android and iOS libraries to the latest ones. * RMET-2844 ::: Android ::: Facebook fix for MABS 10 (#43) * fix: updated facebook-android-sdk version for MABS10 bug. * fix: added sociallogins lib 1.1.1-r1 * chore: updated changelog * chore: bumped version to 1.1.2 * fix: Deep Link Issue (#45) * Fix issue with the deep link, where the plugin would replace all `URLScheme`'s with the ones expected by the plugin. * chore: prepare for release (#46) * updates package version * updates changelog * updates plugin.xml --------- Co-authored-by: OS-ricardomoreirasilva <ricardo.moreira.silva@outsystems.com> Co-authored-by: Ricardo Silva <97543217+OS-ricardomoreirasilva@users.noreply.github.com> Co-authored-by: Alexandre Jacinto <alexandre.jacinto@outsystems.com> Co-authored-by: Nelson Lopes da Silva <5671236+nflsilva@users.noreply.github.com>
OS-martacarlos
added a commit
that referenced
this pull request
Mar 22, 2024
* chore: Add Unreleased Tag to CHANGELOG * fix: Optional Apple SignIn (#36) Apply fix on hook that checks if Apple SignIn should be included on the plugin or not. This is done by changing the Debug and Release Entitlements files. * RMET-2252 :: Remove JSON file dependency , add Endpoint (#38) * feat: add endpoint logic to android hook * fix: add config parser import * removing fetch + add axios * minor typo fix * feat: add get endpoint to iOS * remove static dependency * adding more error handling * chore: refactor * refactor: rename preference to be more accurate * reactor: change preference according to Dev Exp suggestion * fix: change error accordingly * feat: iOS | Update Error Codes (#40) Update error codes. Update library to use new error descriptions. Delete console logs from hook. * RMET-2343 Social Logins Plugin - Update error codes (#39) * feat: format error codes References: https://outsystemsrd.atlassian.net/browse/RMET-2343 * chore: update changelog * fix: fixing typo on error message --------- Co-authored-by: Marta Carlos <marta.carlos@outsystems.com> * chore: Set Release Tag Set Release Tag and update Android and iOS libraries to the latest ones. * RMET-2844 ::: Android ::: Facebook fix for MABS 10 (#43) * fix: updated facebook-android-sdk version for MABS10 bug. * fix: added sociallogins lib 1.1.1-r1 * chore: updated changelog * chore: bumped version to 1.1.2 * fix: Deep Link Issue (#45) Fix issue with the deep link, where the plugin would replace all `URLScheme`'s with the ones expected by the plugin. References: https://outsystemsrd.atlassian.net/browse/RMET-3063 * chore: prepare for release (#46) - updates package version - updates changelog - updates plugin.xml https://outsystemsrd.atlassian.net/browse/RMET-3064 * fix: Deep Link to Specific Screen Issue (#48) Fix the issue with the deep link, where the plugin would not delegate the `ApplicationID` deep link to `CDVAppDelegate`, not making the expected route to the desired screen. References: https://outsystemsrd.atlassian.net/browse/RMET-3139 * RMET-2800 ::: iOS ::: Add new `GIDClientID` Property (#49) * chore: New Google Client ID for iOS library Update 'OSSocialLoginsLib.xcframework' to the latest version. For Google Sign-in, this requires a new property for the 'Info.plist' file: 'GIDClientID'. This is set, if configured, through the 'iOSCopyPreference' hook, based on the Google URL Scheme value. Do some refactoring to the 'iOSCopyPreferences' hook and 'plugin.xml', removing redundant code and unneeded placeholders. References: https://outsystemsrd.atlassian.net/browse/RMET-2800 * chore: Add CHANGELOG entry References: https://outsystemsrd.atlassian.net/browse/RMET-2800 * feat: raise iOS lib (#51) - adds the new version of iOS' lib which raises Google and Facebook dependencies versions - updates changelog and packagejson https://outsystemsrd.atlassian.net/browse/RMET-3236 --------- Co-authored-by: OS-ricardomoreirasilva <ricardo.moreira.silva@outsystems.com> Co-authored-by: Ricardo Silva <97543217+OS-ricardomoreirasilva@users.noreply.github.com> Co-authored-by: Alexandre Jacinto <alexandre.jacinto@outsystems.com> Co-authored-by: Nelson Lopes da Silva <5671236+nflsilva@users.noreply.github.com>
OS-ricardomoreirasilva
added a commit
that referenced
this pull request
Apr 15, 2024
* chore: Add Unreleased Tag to CHANGELOG * fix: Optional Apple SignIn (#36) Apply fix on hook that checks if Apple SignIn should be included on the plugin or not. This is done by changing the Debug and Release Entitlements files. * RMET-2252 :: Remove JSON file dependency , add Endpoint (#38) * feat: add endpoint logic to android hook * fix: add config parser import * removing fetch + add axios * minor typo fix * feat: add get endpoint to iOS * remove static dependency * adding more error handling * chore: refactor * refactor: rename preference to be more accurate * reactor: change preference according to Dev Exp suggestion * fix: change error accordingly * feat: iOS | Update Error Codes (#40) Update error codes. Update library to use new error descriptions. Delete console logs from hook. * RMET-2343 Social Logins Plugin - Update error codes (#39) * feat: format error codes References: https://outsystemsrd.atlassian.net/browse/RMET-2343 * chore: update changelog * fix: fixing typo on error message --------- Co-authored-by: Marta Carlos <marta.carlos@outsystems.com> * chore: Set Release Tag Set Release Tag and update Android and iOS libraries to the latest ones. * RMET-2844 ::: Android ::: Facebook fix for MABS 10 (#43) * fix: updated facebook-android-sdk version for MABS10 bug. * fix: added sociallogins lib 1.1.1-r1 * chore: updated changelog * chore: bumped version to 1.1.2 * fix: Deep Link Issue (#45) Fix issue with the deep link, where the plugin would replace all `URLScheme`'s with the ones expected by the plugin. References: https://outsystemsrd.atlassian.net/browse/RMET-3063 * chore: prepare for release (#46) - updates package version - updates changelog - updates plugin.xml https://outsystemsrd.atlassian.net/browse/RMET-3064 * fix: Deep Link to Specific Screen Issue (#48) Fix the issue with the deep link, where the plugin would not delegate the `ApplicationID` deep link to `CDVAppDelegate`, not making the expected route to the desired screen. References: https://outsystemsrd.atlassian.net/browse/RMET-3139 * RMET-2800 ::: iOS ::: Add new `GIDClientID` Property (#49) * chore: New Google Client ID for iOS library Update 'OSSocialLoginsLib.xcframework' to the latest version. For Google Sign-in, this requires a new property for the 'Info.plist' file: 'GIDClientID'. This is set, if configured, through the 'iOSCopyPreference' hook, based on the Google URL Scheme value. Do some refactoring to the 'iOSCopyPreferences' hook and 'plugin.xml', removing redundant code and unneeded placeholders. References: https://outsystemsrd.atlassian.net/browse/RMET-2800 * chore: Add CHANGELOG entry References: https://outsystemsrd.atlassian.net/browse/RMET-2800 * feat: raise iOS lib (#51) - adds the new version of iOS' lib which raises Google and Facebook dependencies versions - updates changelog and packagejson https://outsystemsrd.atlassian.net/browse/RMET-3236 * feat: update hook error flow (#53) - updates error message with placeholder for plugin specific errors https://outsystemsrd.atlassian.net/browse/RMET-3310 * RMET-3275 ::: iOS ::: Add Privacy Manifest (#54) * chore: Add iOS Dependencies Update `OSSocialLoginsLib.xcframework` to the latest version. Considering that the `xcframework` is now dynamic, the plugin needs to add the 3rd party dependencies, through Cocoapods. References: https://outsystemsrd.atlassian.net/browse/RMET-3275 * chore: Add CHANGELOG entry References: https://outsystemsrd.atlassian.net/browse/RMET-3275 * Prepare release of `2.1.0` (#55) * chore: update iOS library Update to version `1.2.0`. References: https://outsystemsrd.atlassian.net/browse/RMET-3341 * chore: Set Release Version Prepare release of `2.1.0`. Clean `CHANGELOG`. References: https://outsystemsrd.atlassian.net/browse/RMET-3341 --------- Co-authored-by: Marta Carlos <101343976+OS-martacarlos@users.noreply.github.com> Co-authored-by: Alexandre Jacinto <alexandre.jacinto@outsystems.com> Co-authored-by: Marta Carlos <marta.carlos@outsystems.com> Co-authored-by: Nelson Lopes da Silva <5671236+nflsilva@users.noreply.github.com>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the code related to reading/expecting the JSON files from the resources folder. To do so, it adds a dependency on the
axioslibrary, so we can do http requests (Nodejs 12.x does not support Fetch API).This PR also does some minor refactoring to the hook code.
There are successfull builds for iOS and Android, here
Context
For more context, please see this JIRA issue;
Type of changes
Platforms affected
Tests
Use the Sample App (Social Login Mobile - Demo)
Checklist
RNMT-XXXX <title>