RMET-2844 ::: Android ::: Facebook sign in fix #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply fix on hook that checks if Apple SignIn should be included on the plugin or not. This is done by changing the Debug and Release Entitlements files.
* feat: add endpoint logic to android hook * fix: add config parser import * removing fetch + add axios * minor typo fix * feat: add get endpoint to iOS * remove static dependency * adding more error handling * chore: refactor * refactor: rename preference to be more accurate * reactor: change preference according to Dev Exp suggestion * fix: change error accordingly
Update error codes. Update library to use new error descriptions. Delete console logs from hook.
* feat: format error codes References: https://outsystemsrd.atlassian.net/browse/RMET-2343 * chore: update changelog * fix: fixing typo on error message --------- Co-authored-by: Marta Carlos <marta.carlos@outsystems.com>
Set Release Tag and update Android and iOS libraries to the latest ones.
* fix: updated facebook-android-sdk version for MABS10 bug. * fix: added sociallogins lib 1.1.1-r1 * chore: updated changelog * chore: bumped version to 1.1.2
nflsilva
requested review from
OS-ricardomoreirasilva,
alexgerardojacinto and
OS-martacarlos
OS-martacarlos
approved these changes
Oct 24, 2023
OS-ricardomoreirasilva
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brings the Facebook fix into main branch.
Context
https://outsystemsrd.atlassian.net/browse/RMET-2844
Type of changes
Platforms affected
Tests
Tested on MABS 9 and MABS 10.
Screenshots (if appropriate)
Checklist
RNMT-XXXX <title>