RMET-3399 OSBarcodeLib-Android - Prepare to release version 1.1.1
#28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: In order to use version 1.3.0 of the CameraX Library, we need to use at least version 1.4.0 of the Compose Compiler. But to build with MABS 10, we need to use version 1.5.7 of the compose compiler. References: https://outsystemsrd.atlassian.net/browse/RMET-3399
Context: After testing in multiple devices, this only resulted in slower readings rather than better results. References: https://outsystemsrd.atlassian.net/browse/RMET-3399
Context: As we'll be able to use version 1.3.0 of the CameraX library, we can now use this the ImageProxy.toBitmap() method instead of using our own method. References: https://outsystemsrd.atlassian.net/browse/RMET-3399
Context: We're requesting a resolution of 1920x1080 for the frames that will be scanned. If this resolution isn't available on the device, we set the fallback to the closest highest resolution. If that also isn't available, then it will fallback to the closest lower resolution. References: https://outsystemsrd.atlassian.net/browse/RMET-3399
…dability RMET-3399 OSBarcodeLib-Android - Improve code readability by using higher resolution
alexgerardojacinto
requested review from
ItsChaceD,
IT-MikeS,
hectorjdgdev,
OS-ricardomoreirasilva and
OS-martacarlos
and removed request for
a team
|
hectorjdgdev
approved these changes
Apr 30, 2024
OS-martacarlos
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
developmentintomain.Context
Type of changes
Platforms affected
Tests
Screenshots (if appropriate)
Checklist
RNMT-XXXX <title>