-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RMET-3399 OSBarcodeLib-Android - Improve code readability by using higher resolution #27
Merged
alexgerardojacinto
merged 12 commits into
development
from
fix/RMET-3399/improve-code-readability
Apr 30, 2024
Merged
RMET-3399 OSBarcodeLib-Android - Improve code readability by using higher resolution #27
alexgerardojacinto
merged 12 commits into
development
from
fix/RMET-3399/improve-code-readability
Apr 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge `development` into `main`
Merge `development` into `main`
RMET-3312 OSBarcodeLib-Android - Prepare release of version `1.1.0`
Context: In order to use version 1.3.0 of the CameraX Library, we need to use at least version 1.4.0 of the Compose Compiler. But to build with MABS 10, we need to use version 1.5.7 of the compose compiler. References: https://outsystemsrd.atlassian.net/browse/RMET-3399
Context: After testing in multiple devices, this only resulted in slower readings rather than better results. References: https://outsystemsrd.atlassian.net/browse/RMET-3399
Context: As we'll be able to use version 1.3.0 of the CameraX library, we can now use this the ImageProxy.toBitmap() method instead of using our own method. References: https://outsystemsrd.atlassian.net/browse/RMET-3399
Context: We're requesting a resolution of 1920x1080 for the frames that will be scanned. If this resolution isn't available on the device, we set the fallback to the closest highest resolution. If that also isn't available, then it will fallback to the closest lower resolution. References: https://outsystemsrd.atlassian.net/browse/RMET-3399
alexgerardojacinto
changed the title
Fix/rmet 3399/improve code readability
RMET-3399 OSBarcodeLib-Android - Improve code readability by using higher resolution
Apr 30, 2024
Quality Gate passedIssues Measures |
alexgerardojacinto
requested review from
ItsChaceD,
IT-MikeS,
hectorjdgdev,
OS-ricardomoreirasilva and
OS-martacarlos
and removed request for
a team
April 30, 2024 13:21
OS-ricardomoreirasilva
approved these changes
Apr 30, 2024
OS-martacarlos
approved these changes
Apr 30, 2024
hectorjdgdev
approved these changes
Apr 30, 2024
IT-MikeS
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
androidx.camera:camera-camera2:1.3.0
ImagreProxy
objects toBitmap
objects, and as such we were able to remove theimageProxyToBitmap
method.decodeWithState
method instead ofdecode
when scanning with the ZXing library.TRY_HARDER
hint, as from our tests we obtained better results without it.Context
References: https://outsystemsrd.atlassian.net/browse/RMET-3399
Type of changes
Platforms affected
Tests
MABS 10 build: https://intranet.outsystems.net/MABS/BuildDetail.aspx?BuildId=392f8dc4a2c3224bd9eacd9d3d61e130c61dc694
Tested in Pixel 7 with Android 14.
Tested in Samsung A51 with Android 13.
Tested in Pixel 3XL with Android 12.
Screenshots (if appropriate)
Video showing the barcode from the support case being scanned successfully:
screen-20240430-140755.mp4
Checklist
RNMT-XXXX <title>