Skip to content

Refined intergration to Claude AI #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 9, 2025

Conversation

totargaming
Copy link
Contributor

  •   const allowedModels = ['claude-3-opus-20240229', 'claude-3-sonnet-20240229', 'claude-3-haiku-20240307'];
    
  • claude-3-sonnet-20240229: is not valid model
  • claude-3-opus-20240229: bloody expensive compared to claude-3-7-sonnet-latest
    => const allowedModels = ['claude-3-7-sonnet-latest', 'claude-3-5-sonnet-20241022', 'claude-3-haiku-20240307'];

I used replaced all to substitute in the models, and tested it just fine :)

@dev-opsss
Copy link
Collaborator

dev-opsss commented Apr 9, 2025

All the models are Valid models, Not sure where you are checking but using latest is not advised even in anthropic documentation: https://docs.anthropic.com/en/docs/about-claude/models/all-models#model-names

image

@totargaming
Copy link
Contributor Author

totargaming commented Apr 9, 2025

All the models are Valid models, Not sure where you are checking but using latest is not advised even in anthropic documentation: https://docs.anthropic.com/en/docs/about-claude/models/all-models#model-names

  • The problem arose when I tried to use: claude-3-sonnet-20240229, can you please test that model again?. the equivalent can be claude-3-5-sonnet-20241022
  • I have changed 3 tier, claude-3-7-sonnet-latest for anyone want to use latest, its not recommended because the rate and price is subject to change, but I think we all expect to get up to date model. The second tier which is 3.5 is opt-in for user who dont want to have up-to-date model though :)

@totargaming
Copy link
Contributor Author

All the models are Valid models, Not sure where you are checking but using latest is not advised even in anthropic documentation: https://docs.anthropic.com/en/docs/about-claude/models/all-models#model-names

  • The problem arose when I tried to use: claude-3-sonnet-20240229, can you please test that model again?. the equivalent can be claude-3-5-sonnet-20241022
  • I have changed 3 tier, claude-3-7-sonnet-latest for anyone want to use latest, its not recommended because the rate and price is subject to change, but I think we all expect to get up to date model. The second tier which is 3.5 is opt-in for user who dont want to have up-to-date model though :) Opus is more inefficient imo

@bhaumikmaan
Copy link
Collaborator

Let's discuss here #55 and come back to this PR once done

@bhaumikmaan bhaumikmaan linked an issue Apr 9, 2025 that may be closed by this pull request
Copy link
Collaborator

@dev-opsss dev-opsss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@bhaumikmaan
Copy link
Collaborator

Hey
Let's answer #55 @dev-opsss @totargaming
else let's ship

Copy link
Collaborator

@bhaumikmaan bhaumikmaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution

@us1415 us1415 self-requested a review April 9, 2025 17:10
Copy link
Collaborator

@us1415 us1415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw that @dev-opsss had already approved. Approving for him so we could merge.

@bhaumikmaan bhaumikmaan merged commit 65a25d0 into Ornithopter-pilot:main Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opinions: Claude Sonnet VS Opus
4 participants