Docs > Content > Tables: Add design callout messages #2032
Conversation
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
isabellechanclou
added
bug
v5
component
docs
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -80,6 +80,10 @@ Use contextual class to color tables, table rows or individual cells. | |||
|
|
|||
| ## Accented tables | |||
|
|
|||
| {{< design-callout-alert info >}} | |||
| It is possible to use striped rows **or** striped columns in your tables, but you **can't use both in a same table**. | |||
There was a problem hiding this comment.
Should we explain why? 'because it does not respect the Orange Design System specifications' for instance?
There was a problem hiding this comment.
We are not showing examples where we use both in the same table. Is this callout really needed?
There was a problem hiding this comment.
Should we explain why? 'because it does not respect the Orange Design System specifications' for instance?
Good point Mewen. Indeed, it would be better to write: "It is possible to use striped rows or striped columns in your tables, but you can't use both in a same table because it does not respect the Orange Design System specifications."
There was a problem hiding this comment.
We are not showing examples where we use both in the same table. Is this callout really needed?
We thought this design callout message would be necessary to avoid users using both horizontal and vertical striped at the same time, knowing that in the following section "Striped columns", there is an example that could be misleading: it shows 2 striped columns + a striped line (but not the entire line).
There was a problem hiding this comment.
there is an example that could be misleading: it shows 2 striped columns + a striped line (but not the entire line).
Yes, this example is really confusing, it is just striped columns, but in the third line, 2 cells are merged with a colspan="2". (example from Bootstrap)
There was a problem hiding this comment.
IMHO it's obvious that one shouldn't use both at the same time. I vote for not adding this callout. Moreover, the doc doesn't show that they can be used at the same time, it only shows the rendering when there are merged cells.
There was a problem hiding this comment.
It this it only shows the rendering when there are merged cells. that can be confusing to me and motivated my adding the design callout.
|
Kudos, SonarCloud Quality Gate passed!
|
Note: Please transform
- [ ]into- (NA)in the description when things are not applicableRelated issues
#1614
Description
After a design review of all the table variants, it came out that 2 design callout messages needed to be added before variants (accented tables and nesting) that should not be used according to the Orange design system.
Motivation & Context
Change required to prevent Boosted user from using in their app component variants that are not suitable in the Orange Design System.
Types of change
Live previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)
After the merge