-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add design callouts in all the documentation when incompatibility with ODS #1614
Conversation
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
…e of the design callouts on Getting started Introduction page Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some global comments, feel free to debate about these.
I'd rather use should not
instead of can not
almost everywhere in the callouts.
The way they are implemented yet make me feel that a callout is for the entire subpart.
Wondering if we should redirect to a usable Boosted variant on each callout ?
Maybe be more descriptive on some components.
Maybe we should on some examples explain why we shouldn't use this particular example but the concepts behind are still usable ?
We don't have specs for placeholders but is it fine to use them ?
Be brave for the migration guide change !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed up to customize-colors included
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
…ocs' into main-ic-add-design-callouts-in-docs Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
… >}} everywhere in the code Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still some comments inside the PR to take into account but we're almost there I think.
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
…ng the dark mode now available on main branch Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the last changes, I'd rather set a global callout on badges to avoid hiding everything.
One .nav-underline.nav-justified
render is broken.
Revert 4fcd51d if you don't like it.
a0a8251
to
4fcd51d
Compare
Thanks a lot for this work. It has been gathered and merged with other modifications in #2625. All participants of this PR will be mentioned as co-authors in it. |
Related issues
Closes #1199
Closes #1118
Closes #1117
Description
Everywhere needed in Boosted Docs, a callout message has been added.
Motivation & Context
Callout messages added to warn Boosted users that such component or component variant should not be used because incompatible with the orange design system specifications.
Types of change
Live previews
Checklist
npm run lint
)