Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix popover's arrow appearance #1936

Merged
merged 13 commits into from
Apr 26, 2023
Merged

Fix popover's arrow appearance #1936

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8c829c6
Fix comments
MewenLeHo Mar 30, 2023
0c9abd6
Fix border width
MewenLeHo Mar 30, 2023
3943e66
Fix border width
MewenLeHo Mar 31, 2023
6889c21
Fix stylelint multiline comments
MewenLeHo Mar 31, 2023
59beb4b
Merge branch 'main' into main-mlh-fix-popover-arrow
MewenLeHo Apr 4, 2023
e047ffe
Merge branch 'main' into main-mlh-fix-popover-arrow
MewenLeHo Apr 5, 2023
65bdf38
Fix
MewenLeHo Apr 12, 2023
e956895
Improve fix
MewenLeHo Apr 12, 2023
23cfc62
Improve fix
MewenLeHo Apr 12, 2023
0962d8b
Merge branch 'main' into main-mlh-fix-popover-arrow
MewenLeHo Apr 12, 2023
3d5b60c
Merge branch 'main' into main-mlh-fix-popover-arrow
MewenLeHo Apr 17, 2023
c21e54a
Merge branch 'main' into main-mlh-fix-popover-arrow
MewenLeHo Apr 24, 2023
bbdc7a1
Merge branch 'main' into main-mlh-fix-popover-arrow
MewenLeHo Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions scss/_popover.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@
}

&::after {
bottom: var(--#{$prefix}popover-border-width);
// stylelint-disable-next-line function-disallowed-list
bottom: calc(var(--#{$prefix}popover-border-width) * 1.5); // Boosted mod: instead of `var(--#{$prefix}popover-border-width)`
border-top-color: var(--#{$prefix}popover-bg);
}
}
Expand All @@ -99,7 +100,8 @@
}

&::after {
left: var(--#{$prefix}popover-border-width);
// stylelint-disable-next-line function-disallowed-list
left: calc(var(--#{$prefix}popover-border-width) * 1.5); // Boosted mod: instead of `var(--#{$prefix}popover-border-width)`
border-right-color: var(--#{$prefix}popover-bg);
}
}
Expand All @@ -122,7 +124,8 @@
}

&::after {
top: var(--#{$prefix}popover-border-width);
// stylelint-disable-next-line function-disallowed-list
top: calc(var(--#{$prefix}popover-border-width) * 1.5); // Boosted mod: instead of `var(--#{$prefix}popover-border-width)`
border-bottom-color: var(--#{$prefix}popover-bg);
}
}
Expand Down Expand Up @@ -158,7 +161,8 @@
}

&::after {
right: var(--#{$prefix}popover-border-width);
// stylelint-disable-next-line function-disallowed-list
right: calc(var(--#{$prefix}popover-border-width) * 1.5); // Boosted mod: instead of `var(--#{$prefix}popover-border-width)`
border-left-color: var(--#{$prefix}popover-bg);
}
}
Expand Down