Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix popover's arrow appearance #1936

Merged
merged 13 commits into from
Apr 26, 2023
Merged

Conversation

MewenLeHo
Copy link
Contributor

@MewenLeHo MewenLeHo commented Mar 30, 2023

Related issues

Closes #1922

Description

Improve the rendering of popover's arrow.

Motivation & Context

Improve rendering and better compliance to design system.

Before:
227896322-7746be93-6a53-4ebf-8185-73ca1146da8a

After:
screenshot-deploy-preview-1936--boosted netlify app-2023 03 30-18_33_48

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

Checklist

Contribution

Accessibility

  • (NA) My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with responsive display

Development

  • My change follows the developer guide
  • (NA) I have added JavaScript unit tests to cover my changes
  • (NA) I have added SCSS unit tests to cover my changes

Documentation

  • (NA) My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • (NA) My change introduces changes to the migration guide
  • (NA) My new component is added in Storybook
  • My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • (NA) A11y review

After the merge

@netlify
Copy link

netlify bot commented Mar 30, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit bbdc7a1
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6448ed46263c9a00088fe823
😎 Deploy Preview https://deploy-preview-1936--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rendering looks great, however I don't quite like the actual implementation

scss/_popover.scss Outdated Show resolved Hide resolved
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julien-deramond julien-deramond self-requested a review April 26, 2023 10:56
@julien-deramond julien-deramond merged commit 6ee9b0c into main Apr 26, 2023
@julien-deramond julien-deramond deleted the main-mlh-fix-popover-arrow branch April 26, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Improve popover's arrow appearance
3 participants