Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix content margin at the bottom of scrollable modal #1661

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

hannahiss
Copy link
Member

@hannahiss hannahiss commented Nov 25, 2022

Related issues

Fixes #1602

Description

Removed rule to prevent scrollable modals to not having bottom margin on last paragraph of modal-body (in contrary of other modals)

Motivation & Context

Resolves design problem of having a too big margin at the bottom of scrollable modals

Types of change

  • Bug fix (non-breaking which fixes an issues)

Live previews

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • My change introduces changes to the migration guide
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@netlify
Copy link

netlify bot commented Nov 25, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 82545d9
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6384662cfe7bb40008a47f39
😎 Deploy Preview https://deploy-preview-1661--boosted.netlify.app/docs/5.2/components/navbar
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Nov 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs > Components > Modal: fix content margin at the bottom of the modal
2 participants