Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms > Quantity selector #113

Closed
Tracked by #1048
PigeardSylvain opened this issue Jan 30, 2019 · 4 comments · Fixed by #860
Closed
Tracked by #1048

Forms > Quantity selector #113

PigeardSylvain opened this issue Jan 30, 2019 · 4 comments · Fixed by #860

Comments

@PigeardSylvain
Copy link
Member

PigeardSylvain commented Jan 30, 2019

References

  • Orange Design System: Components > Forms
    • Quantity selector — WEB-FOR-QUS-001
    • Quantity selector — WEB-FOR-QUS-002
@ffoodd
Copy link
Contributor

ffoodd commented Nov 13, 2019

This will require some JavaScript to be cross-browser, since the CSS way is Chrome-only for now…

To sum up, it'll need:

  • two buttons, beside input,
  • each on triggering the input's stepUp() or stepDown() methods,
  • and obviously hide the spinner button by defining appearance: none — maybe when input:not(:only-child)?

And test this in every browsers and ATs.

@ffoodd ffoodd added enhancement js Pull requests that update Javascript code v5 labels Nov 13, 2019
@ffoodd ffoodd self-assigned this Nov 13, 2019
@ffoodd ffoodd added the feature label Dec 4, 2019
@ffoodd ffoodd added this to the 5.0.0 milestone Jan 16, 2020
@ffoodd ffoodd changed the title [Boosted vs Brand stencils] quantity selector Quantity selector Jan 16, 2020
@ffoodd ffoodd removed the js Pull requests that update Javascript code label Jan 16, 2020
@ffoodd
Copy link
Contributor

ffoodd commented Apr 24, 2020

New reference about input type="number" and to sum up, why it should be avoided: "Why the GOV.UK Design System team changed the input type for numbers".

@ffoodd ffoodd added the brand label Oct 12, 2020
@ffoodd ffoodd added the effort:5 label Nov 9, 2020
@ffoodd ffoodd modified the milestones: 5.0.0, 5.0.0-beta Nov 12, 2020
@ffoodd ffoodd removed their assignment Feb 26, 2021
@julien-deramond julien-deramond removed this from the 5.0.0-beta milestone Oct 15, 2021
@MewenLeHo MewenLeHo self-assigned this Oct 18, 2021
julien-deramond pushed a commit that referenced this issue Feb 24, 2022
julien-deramond pushed a commit that referenced this issue Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants