Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

Contribution: I want to review the changes applied after acceptance #284

Closed
FinnWoelm opened this issue Feb 1, 2019 · 1 comment
Closed

Contribution: I want to review the changes applied after acceptance #284

FinnWoelm opened this issue Feb 1, 2019 · 1 comment
Assignees
@FinnWoelm
Labels
enhancement Issues that will enhance the user experience
Milestone
Contributions 2.0

Comments

@FinnWoelm
Copy link
Contributor

After accepting a contribution, it is no longer possible to review the changes introduced by that contribution. The review tab should still be accessible and should show the changes that have been made & accepted.
@FinnWoelm FinnWoelm added the enhancement Issues that will enhance the user experience label Feb 1, 2019
@FinnWoelm FinnWoelm added this to the Contributions 2.0 milestone Feb 1, 2019
@FinnWoelm FinnWoelm self-assigned this Feb 17, 2019
@FinnWoelm FinnWoelm mentioned this issue Feb 17, 2019
Closed
FinnWoelm added a commit that referenced this issue Feb 17, 2019
@FinnWoelm
Contribution review: Show accepted changes after acceptance
f160b22 
When a contribution has been accepted, show the accepted changes on the
contribution's review page.

Resolves [#284](https://github.com/OpenlyOne/openly/issues/284)
Fixes [#283](https://github.com/OpenlyOne/openly/issues/283)
@FinnWoelm FinnWoelm mentioned this issue Feb 17, 2019
Merged
FinnWoelm added a commit that referenced this issue Feb 17, 2019
@FinnWoelm
Merge branch 'track-accepted-revision-in-contribution' into development
c8f89a4 
Contribution: Track accepted revision

Add a column `accepted_revision_id` to keep track of the revision
created for accepting the contribution. For now the column is used to
display an accurate list of accepted changes in the review tab for
accepted contributions. This column also replaces the now redundant
`is_accepted` column.

Resolves [#284](https://github.com/OpenlyOne/openly/issues/284)
Fixes [#283](https://github.com/OpenlyOne/openly/issues/283)
@FinnWoelm
Copy link
Contributor Author

Resolved by #331

@FinnWoelm FinnWoelm mentioned this issue Feb 18, 2019
Merged
FinnWoelm added a commit that referenced this issue Feb 18, 2019
@FinnWoelm
Merge branch 'release-0.36'
870ca0d 
Release v0.36: Relative contributions and contribution replies

**Features:**
- Changes suggested in contributions are now relative to point in time
  when the contribution was created. In addition, only files with
  suggested changes will be overwritten in the project. Any other files
  in the project, whether changed or not, will remain untouched when
  accepting the contribution.
  ([#325](https://github.com/OpenlyOne/openly/issues/325))
- Contributions now have a discussion tab where users can create replies
  to the contribution and discuss it. When a reply is created, it
  notifies the project team, contribution creator, and other discussion
  participants.
  ([#280](https://github.com/OpenlyOne/openly/issues/280))

**Enhancements:**
- The contributions feature is now enabled for all projects. The feature
  toggle has been removed.
- Creating and accepting a contribution now triggers notifications to
  the project team, contribution creator, and contribution discussion
  participants
  ([#285](https://github.com/OpenlyOne/openly/issues/285))
- Add a link to the contribution navigation to allow users to open the
  contribution's root folder in Google Drive
  ([#273](https://github.com/OpenlyOne/openly/issues/273))
- Display an accurate list of changes in the contribution review tab
  after the contribution has been accepted by tracking the accepted
  revision
  ([#284](https://github.com/OpenlyOne/openly/issues/284))
- Admins can edit email addresses of accounts via the admin panel. Users
  continue to be prevented from editing their own email addresses.
  ([#266](https://github.com/OpenlyOne/openly/issues/266))
FinnWoelm added a commit that referenced this issue Feb 18, 2019
@FinnWoelm
Merge branch 'release-0.36' into development
3d15cba 
Release v0.36: Relative contributions and contribution replies

**Features:**
- Changes suggested in contributions are now relative to point in time
  when the contribution was created. In addition, only files with
  suggested changes will be overwritten in the project. Any other files
  in the project, whether changed or not, will remain untouched when
  accepting the contribution.
  ([#325](https://github.com/OpenlyOne/openly/issues/325))
- Contributions now have a discussion tab where users can create replies
  to the contribution and discuss it. When a reply is created, it
  notifies the project team, contribution creator, and other discussion
  participants.
  ([#280](https://github.com/OpenlyOne/openly/issues/280))

**Enhancements:**
- The contributions feature is now enabled for all projects. The feature
  toggle has been removed.
- Creating and accepting a contribution now triggers notifications to
  the project team, contribution creator, and contribution discussion
  participants
  ([#285](https://github.com/OpenlyOne/openly/issues/285))
- Add a link to the contribution navigation to allow users to open the
  contribution's root folder in Google Drive
  ([#273](https://github.com/OpenlyOne/openly/issues/273))
- Display an accurate list of changes in the contribution review tab
  after the contribution has been accepted by tracking the accepted
  revision
  ([#284](https://github.com/OpenlyOne/openly/issues/284))
- Admins can edit email addresses of accounts via the admin panel. Users
  continue to be prevented from editing their own email addresses.
  ([#266](https://github.com/OpenlyOne/openly/issues/266))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@FinnWoelm FinnWoelm

Labels
enhancement Issues that will enhance the user experience
Projects
None yet
Milestone
Contributions 2.0
Development

No branches or pull requests
1 participant
@FinnWoelm