This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
Contribution: Review is incorrect when contribution has been accepted #283
Comments
|
Better solution is to allow users to view accepted changes: See #284 |
FinnWoelm
added a commit
that referenced
this issue
Feb 17, 2019
When a contribution has been accepted, show the accepted changes on the contribution's review page. Resolves [#284](https://github.com/OpenlyOne/openly/issues/284) Fixes [#283](https://github.com/OpenlyOne/openly/issues/283)
FinnWoelm
added a commit
that referenced
this issue
Feb 17, 2019
Contribution: Track accepted revision Add a column `accepted_revision_id` to keep track of the revision created for accepting the contribution. For now the column is used to display an accurate list of accepted changes in the review tab for accepted contributions. This column also replaces the now redundant `is_accepted` column. Resolves [#284](https://github.com/OpenlyOne/openly/issues/284) Fixes [#283](https://github.com/OpenlyOne/openly/issues/283)
|
Fixed by #331 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When a contribution has been accepted, the information on the review tab becomes incorrect because it shows the delta of files in contribution to files in last revision (which becomes 0 when accepting the contribution).
Possible fix: Hide review tab when contribution has been accepted?
The text was updated successfully, but these errors were encountered: