Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1358 Test helper to send funds #1367

Merged
merged 13 commits into from
Oct 1, 2018
Merged

Fix #1358 Test helper to send funds #1367

merged 13 commits into from
Oct 1, 2018

Conversation

Aniket-Engg
Copy link
Contributor

@Aniket-Engg Aniket-Engg commented Oct 1, 2018 •
edited
Loading

Fixes #1358

🚀 Description

Test helper for sending funds has been added and tested in BreakInvariantBounty.test.js

  • 📘 I've reviewed the OpenZeppelin Contributor Guidelines
  • ✅ I've added tests where applicable to test my new functionality.
  • 📖 I've made sure that my contracts are well-documented.
  • 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:fix).

@nventuro nventuro self-assigned this Oct 1, 2018
@nventuro nventuro added feature New contracts, functions, or helpers. tests Test suite and helpers. labels Oct 1, 2018
nventuro
nventuro reviewed Oct 1, 2018
View reviewed changes
Copy link
Contributor

@nventuro nventuro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Aniket-Engg, thanks a lot for taking care of this! Left a couple review comments.

Also, could you remove the .eslintrc and package-lock.json changes from the PR? Thanks!

test/helpers/sendTransaction.js Show resolved Hide resolved
test/BreakInvariantBounty.test.js Show resolved Hide resolved
nventuro
nventuro approved these changes Oct 1, 2018
View reviewed changes
Copy link
Contributor

@nventuro nventuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo, thanks for the quick response @Aniket-Engg!

@nventuro nventuro merged commit fa1dfbd into OpenZeppelin:master Oct 1, 2018
@Aniket-Engg
Copy link
Contributor Author

Thank you so much ! @nventuro

come-maiz pushed a commit that referenced this pull request Oct 21, 2018
@Aniket-Engg @come-maiz
Fix #1358 Test helper to send funds (#1367)
c25a1e3 
* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a688977.

* fixes #1358

* linting done

* suggested changes

(cherry picked from commit fa1dfbd)
@Aniket-Engg Aniket-Engg deleted the fix-#1358 branch December 10, 2018 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nventuro nventuro nventuro approved these changes

Assignees

@nventuro nventuro

Labels
feature New contracts, functions, or helpers. tests Test suite and helpers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test helper to send funds
2 participants
@Aniket-Engg @nventuro