Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test helper to send funds #1358

Closed
nventuro opened this issue Sep 26, 2018 · 0 comments · Fixed by #1367
Closed

Add test helper to send funds #1358

nventuro opened this issue Sep 26, 2018 · 0 comments · Fixed by #1367
Labels
feature New contracts, functions, or helpers. good first issue Low hanging fruit for new contributors to get involved! tests Test suite and helpers.
Milestone
v2.0

Comments

@nventuro
Copy link
Contributor

We've sometimes created local helpers to do this (see here), but it is sort of dirty: we should have a simple wrapper for ethSendTransaction with just to, from and value.
@nventuro nventuro added feature New contracts, functions, or helpers. good first issue Low hanging fruit for new contributors to get involved! tests Test suite and helpers. labels Sep 26, 2018
@nventuro nventuro added this to the v2.1 milestone Sep 26, 2018
@nventuro nventuro mentioned this issue Sep 26, 2018
Merged
Aniket-Engg added a commit to Aniket-Engg/zeppelin-solidity that referenced this issue Oct 1, 2018
@Aniket-Engg
fixes OpenZeppelin#1358
9432eaf
@Aniket-Engg Aniket-Engg mentioned this issue Oct 1, 2018
Merged
4 tasks
nventuro pushed a commit that referenced this issue Oct 1, 2018
@Aniket-Engg @nventuro
Fix #1358 Test helper to send funds (#1367)
fa1dfbd 
* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a688977.

* fixes #1358

* linting done

* suggested changes
come-maiz pushed a commit that referenced this issue Oct 21, 2018
@Aniket-Engg @come-maiz
Fix #1358 Test helper to send funds (#1367)
c25a1e3 
* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a688977.

* fixes #1358

* linting done

* suggested changes

(cherry picked from commit fa1dfbd)
@come-maiz come-maiz modified the milestones: v2.1, v2.0 Oct 21, 2018
@dependabot-preview dependabot-preview bot mentioned this issue May 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New contracts, functions, or helpers. good first issue Low hanging fruit for new contributors to get involved! tests Test suite and helpers.
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

Fix #1358 Test helper to send funds Aniket-Engg/zeppelin-solidity
2 participants
@come-maiz @nventuro