Skip to content
This repository has been archived by the owner on Feb 11, 2024. It is now read-only.

Catch and handle missing optional skill files #76

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Catch and handle missing optional skill files #76

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ca4fb5
Catch and handle missing optional skill files
NeonDaniel Dec 14, 2021
b9bf79d
Handle requirements.txt too
NeonDaniel Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ovos_skills_manager/github/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,8 @@ def get_requirements_json(url, branch=None):
try:
manif = get_manifest(url, branch)
data = manif['dependencies'] or {}
except GithubFileNotFound:
LOG.debug("No manifest file available")
except GithubSkillEntryError:
LOG.error("Error reading from manifest!")
data["python"] = data.get("python") or []
Expand All @@ -213,11 +215,15 @@ def get_requirements_json(url, branch=None):
try:
req = get_requirements(url, branch)
data["python"] = list(set(data["python"] + req))
except GithubFileNotFound:
LOG.debug("No python requirements file available")
except GithubSkillEntryError:
LOG.error("Error reading from requirements files!")
try:
skill_req = get_skill_requirements(url, branch)
data["skill"] = list(set(data["skill"] + skill_req))
except GithubFileNotFound:
LOG.debug("No skill requirements file available")
except GithubSkillEntryError:
LOG.error("Error reading skills requirements!")
return data
Expand Down