This repository has been archived by the owner on Feb 11, 2024. It is now read-only.
Catch and handle missing optional skill files #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested against neon-core here |
NeonDaniel
force-pushed
the
FEAT_DecreaseLoggedInstallErrors
branch
from
48c12b0 to
b9bf79d
Compare
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
==========================================
+ Coverage 56.38% 56.47% +0.09%
==========================================
Files 33 33
Lines 2680 2686 +6
==========================================
+ Hits 1511 1517 +6
Misses 1169 1169
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing skills from git URLs will log errors if
manifest.ymlandskill_requirements.txtare missing, but most skills don't define these files. This PR handles these exceptions and logs todebuginstead oferror.