Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "logging" section to allow per-service log level changes #189

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

lbt
Copy link
Contributor

@lbt lbt commented Aug 31, 2023

Add a "logging" section to the config to allow per-service log levels to be set.

Added comments and documentation,
If we should be doing a dict merge then maybe that's worth considering

Signed-off-by: David Greaves <david@dgreaves.com>
@goldyfruit
Copy link
Member

goldyfruit commented Aug 31, 2023

Adding this feature back to OVOS would be nice as well: MycroftAI/mycroft-core@0247b3a

Or maybe a more natural JSON log format option. (json, text)

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (22bf10c) 28.43% compared to head (46654ae) 28.41%.
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #189      +/-   ##
==========================================
- Coverage   28.43%   28.41%   -0.03%     
==========================================
  Files          49       49              
  Lines        6491     6496       +5     
==========================================
  Hits         1846     1846              
- Misses       4645     4650       +5     
Files Changed Coverage Δ
ovos_utils/log.py 81.56% <0.00%> (-3.00%) ⬇️
ovos_utils/version.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl added the enhancement New feature or request label Sep 26, 2023
@JarbasAl
Copy link
Member

thanks for the contribution! this is a simple but very useful addition

@JarbasAl JarbasAl merged commit ab7843a into OpenVoiceOS:dev Sep 26, 2023
9 of 10 checks passed
@github-actions github-actions bot mentioned this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants