Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Suggested changes to the utils code #185

Closed
wants to merge 4 commits into from
Closed

Conversation

lbt
Copy link
Contributor

@lbt lbt commented Aug 24, 2023

Some suggested changes to improve the code flow and to support per-service log-level tweaks

Signed-off-by: David Greaves <david@dgreaves.com>
Signed-off-by: David Greaves <david@dgreaves.com>
Signed-off-by: David Greaves <david@dgreaves.com>
@ChanceNCounter ChanceNCounter added the enhancement New feature or request label Aug 24, 2023
Signed-off-by: David Greaves <david@dgreaves.com>
@JarbasAl JarbasAl requested review from ChanceNCounter and a team August 30, 2023 16:46
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 23.25% and project coverage change: +0.09% 🎉

Comparison is base (22bf10c) 28.43% compared to head (29ba73f) 28.53%.
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #185      +/-   ##
==========================================
+ Coverage   28.43%   28.53%   +0.09%     
==========================================
  Files          49       49              
  Lines        6491     6483       -8     
==========================================
+ Hits         1846     1850       +4     
+ Misses       4645     4633      -12     
Files Changed Coverage Δ
ovos_utils/log.py 81.56% <0.00%> (-3.00%) ⬇️
ovos_utils/version.py 0.00% <0.00%> (ø)
ovos_utils/sound/__init__.py 65.51% <27.77%> (+7.92%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ovos_utils/sound/__init__.py Show resolved Hide resolved
ovos_utils/sound/__init__.py Show resolved Hide resolved
ovos_utils/sound/__init__.py Show resolved Hide resolved
ovos_utils/sound/__init__.py Show resolved Hide resolved
@ChanceNCounter ChanceNCounter requested review from JarbasAl and removed request for a team August 30, 2023 17:32
@lbt lbt closed this Aug 31, 2023
@lbt lbt mentioned this pull request Aug 31, 2023
@lbt
Copy link
Contributor Author

lbt commented Aug 31, 2023

I should not have mixed up so many areas into this PR. My bad.

Broken out into more reviewable chunks

Refactoring play_SOME_sound() to be DRY and adding a bus arg to support remote playing:
#188

Adding a "logging" config section: #189

Improving the sound executable scanning: #187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants