Add optional dependencies and make backend optional #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add extra dependency note to `README.md` Make backend imports optional with logging around upload calls
JarbasAl
reviewed
Oct 12, 2023
JarbasAl
reviewed
Oct 12, 2023
| ovos-microphone-plugin-alsa~=0.0.0 | ||
| ovos-stt-plugin-server~=0.0.3 | ||
| ovos-ww-plugin-precise-lite[full]~=0.1 | ||
| ovos-vad-plugin-webrtcvad~=0.0.1 |
There was a problem hiding this comment.
Want to make this one optional too, pending a new plugin based on noise threshold only like original listener
If we are adding an extra with new deps, it should be silero instead, if it's an extra it's fine
There was a problem hiding this comment.
I pulled the default from ovos-config default configuration; I don't have a strong preference between the 2 plugins but I think the extras should make things work without extra config
There was a problem hiding this comment.
silero requires onnxruntime or tflite-runtime (don't remember which one), webrtcvad would be more simple to install.
NeonDaniel
added a commit
to NeonGeckoCom/neon_speech
that referenced
this pull request
Oct 13, 2023
NeonDaniel
added a commit
to NeonGeckoCom/neon_speech
that referenced
this pull request
Oct 13, 2023
# Description Update dependencies for compat. with OpenVoiceOS/ovos-dinkum-listener#67 # Issues Needs OpenVoiceOS/ovos-dinkum-listener#67 # Other Notes <!-- Note any breaking changes, WIP changes, requests for input, etc. here --> --------- Co-authored-by: Daniel McKnight <daniel@neon.ai>
JarbasAl
pushed a commit
that referenced
this pull request
Nov 24, 2023
Co-authored-by: Daniel McKnight <daniel@neon.ai>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move default mic and backend client dependencies to extras
Add extra dependency note to
README.mdMake backend imports optional with logging around upload calls
Closes #13
Closes #52