Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/blacklist_from_session #492

Merged
merged 10 commits into from
Jun 17, 2024
Merged

feat/blacklist_from_session #492

merged 10 commits into from
Jun 17, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Jun 3, 2024

allow skill_id and intents to be blacklisted in the Session, these will be ignored during the matching process

this allows finetuning utterances and permissions per client, taking it into account during the match process instead of filtering before/after the handling of the utterance

needed for hivemind RBAC

needs OpenVoiceOS/ovos-bus-client#98

NOTE: this ensures skill blacklist is respected even when skills are launched in standalone mode. otherwise a standalone mode skill could bypass the blacklist, closes #493

{
	"intents": {"blacklisted_intents": ["skill_id:intent_name"]},
	"skills": {"blacklisted_skills": ["skill_id"]},
}

@JarbasAl JarbasAl added the enhancement New feature or request label Jun 3, 2024
@JarbasAl JarbasAl requested a review from goldyfruit June 3, 2024 00:38
@JarbasAl JarbasAl self-assigned this Jun 3, 2024
JarbasAl added a commit to OpenVoiceOS/ovos-bus-client that referenced this pull request Jun 3, 2024
allow skill_id and intents to be blacklisted in the Session, these will be ignored during the matching process

this allows finetuning utterances and permissions per client, taking it into account during the match process instead of filtering before/after the handling of the utterance

needed for hivemind RBAC

companion to OpenVoiceOS/ovos-core#492
@JarbasAl JarbasAl requested review from mikejgray, NeonDaniel and a team June 3, 2024 16:36
@JarbasAl JarbasAl added the bug Something isn't working label Jun 4, 2024
JarbasAl added a commit to OpenVoiceOS/ovos-bus-client that referenced this pull request Jun 5, 2024
allow skill_id and intents to be blacklisted in the Session, these will be ignored during the matching process

this allows finetuning utterances and permissions per client, taking it into account during the match process instead of filtering before/after the handling of the utterance

needed for hivemind RBAC

companion to OpenVoiceOS/ovos-core#492
allow skill_id and intents to be blacklisted in the Session, these will be ignored during the matching process

this allows finetuning utterances and permissions per client, taking it into account during the match process instead of filtering before/after the handling of the utterance

needed for hivemind RBAC
@JarbasAl JarbasAl force-pushed the feat/blacklist_from_session branch from 4990f62 to 7c03f86 Compare June 16, 2024 23:53
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 78.43137% with 22 lines in your changes missing coverage. Please review.

Project coverage is 73.65%. Comparing base (cffc8a8) to head (76e983f).
Report is 2 commits behind head on dev.

Files Patch % Lines
ovos_core/intent_services/fallback_service.py 72.22% 5 Missing ⚠️
ovos_core/intent_services/__init__.py 33.33% 4 Missing ⚠️
ovos_core/intent_services/stop_service.py 55.55% 4 Missing ⚠️
ovos_core/intent_services/commonqa_service.py 57.14% 3 Missing ⚠️
ovos_core/intent_services/converse_service.py 33.33% 2 Missing ⚠️
ovos_core/intent_services/padacioso_service.py 88.88% 2 Missing ⚠️
ovos_core/intent_services/ocp_service.py 93.75% 1 Missing ⚠️
ovos_core/intent_services/padatious_service.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #492      +/-   ##
==========================================
+ Coverage   73.22%   73.65%   +0.43%     
==========================================
  Files          15       15              
  Lines        3085     3143      +58     
==========================================
+ Hits         2259     2315      +56     
- Misses        826      828       +2     
Flag Coverage Δ
unittests 73.65% <78.43%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl marked this pull request as ready for review June 17, 2024 01:55
@JarbasAl JarbasAl merged commit c074d3a into dev Jun 17, 2024
8 checks passed
@JarbasAl JarbasAl deleted the feat/blacklist_from_session branch June 17, 2024 03:57
@JarbasAl JarbasAl added this to the 0.0.8 milestone Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

standalone skills dont respect blacklist
1 participant