Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standalone skills dont respect blacklist #493

Closed
JarbasAl opened this issue Jun 3, 2024 · 0 comments · Fixed by #492
Closed

standalone skills dont respect blacklist #493

JarbasAl opened this issue Jun 3, 2024 · 0 comments · Fixed by #492
Assignees
@JarbasAl
Labels
bug Something isn't working security
Milestone
0.0.8

Comments

@JarbasAl
Copy link
Member

JarbasAl commented Jun 3, 2024

if a skill is launched standalone it bypasses the blacklisted_skills from config

#492 ensures the skill will not match even if loaded

a companion PR should also be made in ovos-workshop skill loader, to save resources by not even loading the skill
@JarbasAl JarbasAl added the bug Something isn't working label Jun 3, 2024
@JarbasAl JarbasAl added this to the 0.0.8 milestone Jun 3, 2024
@JarbasAl JarbasAl self-assigned this Jun 3, 2024
@JarbasAl JarbasAl mentioned this issue Jun 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JarbasAl JarbasAl

Labels
bug Something isn't working security
Projects
None yet
Milestone
0.0.8
Development

Successfully merging a pull request may close this issue.

feat/blacklist_from_session OpenVoiceOS/ovos-core
1 participant
@JarbasAl