Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some dep updates #1731

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Some dep updates #1731

merged 1 commit into from
Aug 11, 2020

Conversation

Martii
Copy link
Member

@Martii Martii commented Aug 11, 2020

  • Delete op retested.
  • terser has a breaking change with returning a promise instead of an error in 5.0.0 . This will need additional debug time to restore minification... so skipping update for now especially since it probably affects express-minify dep.
  • Repo owner name change for sanitize-html from GH redirect.
  • Adopt Chromium/Chromes url hash for showing script raw source with bypass=true... should be okay with all .user.js engines and shouldn't trigger their handlers. Chromium here, as of right now, doesn't appear to have native .user.js support any more.

* Delete op retested.
* *terser* has a breaking change with returning a promise instead of an error in 5.0.0 .  This will need additional debug time to restore minification... so skipping update for now especially since it probably affects *express-minify* dep.
* Repo owner name change for *sanitize-html* from GH redirect.
* Adopt Chromium/Chromes url hash for showing script raw source with `bypass=true`... should be okay with all .user.js engines and shouldn't trigger their handlers. Chromium here, as of right now, doesn't appear to have native .user.js support any more.
@Martii Martii added migration Use this to indicate that it may apply to an existing or announced migration. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Aug 11, 2020
@Martii Martii merged commit 0c5e3e5 into OpenUserJS:master Aug 11, 2020
@Martii Martii deleted the someDepUpdates branch August 11, 2020 07:48
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Aug 17, 2020
Instances:
1. Author has webhook enabled and GH sends update notice before imported on OUJS.
2. Author deleted OUJS script and still receiving webhook notice.

There's still the extremely rare chance that this could be a 500, if *mongoose*,*mongodb*, and S3 has a catastrophic connection error.

Since the bulk of this is usually client error denoting as such in case GH is paying attention and possibly doing something on their end by killing further notices. If true then this part "could be" related to OpenUserJS#1730

Post OpenUserJS#1731
Martii added a commit that referenced this pull request Aug 17, 2020
Instances:
1. Author has webhook enabled and GH sends update notice before imported on OUJS.
2. Author deleted OUJS script and still receiving webhook notice.

There's still the extremely rare chance that this could be a 500, if *mongoose*,*mongodb*, and S3 has a catastrophic connection error.

Since the bulk of this is usually client error denoting as such in case GH is paying attention and possibly doing something on their end by killing further notices. If true then this part "could be" related to #1730

Post #1731

Auto-merge
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Sep 25, 2020
* Catch GH import routine
* Add `#bypass` to statusCodePage

Post OpenUserJS#1731 , applies to OpenUserJS#430 OpenUserJS#37 and closes OpenUserJS#1730
@Martii Martii mentioned this pull request Sep 25, 2020
Martii added a commit that referenced this pull request Sep 25, 2020
* Catch GH import routine
* Add `#bypass` to statusCodePage

Post #1731 , applies to #430 #37 and closes #1730

Auto-merge
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. migration Use this to indicate that it may apply to an existing or announced migration.
Development

Successfully merging this pull request may close these issues.

1 participant