WebHooks aren't being processed?

[joeytwiddle]

I often push updates to my userscripts, but it seems some of the new versions haven't been loaded from github for some time, whilst others have: https://openuserjs.org/users/joeytwiddle/scripts

For example, this one has changed a few times (see its History): https://github.com/joeytwiddle/code/blob/master/other/gm_scripts/Related_Links_Pager/Related_Links_Pager.user.js

Do you have some debugging information about which part of the hooks process has a problem?

The script mentioned above is 50KB, well within the 1MB limit specific in settings.json (at least in the dev settings).

I see the hooks process starts at exports.webhook in scriptStorage.js and goes on to call repoManager.prototype.loadScripts in repoManager.js.

I would assume the fetchRaw() is working as it is, but if you want me to add authentication to that, I could do that.

---

I just did a push to GitHub at new Date(1596957303135) so perhaps you might see something logged around that time.
https://openuserjs.org/scripts/joeytwiddle/Wikipedia_Inline_Article_Viewer
https://github.com/joeytwiddle/code/blob/master/other/gm_scripts/wikipedia_inline_article/wikipedia_inline_article.user.js

[Martii]

@joeytwiddle

Do you have some debugging information about which part of the hooks process has a problem?

We do not. We return the http status codes that shows up in your webhook logs on GH only. Browsing through the console messages in our source for errs I see nothing related to your account on OUJS. May have an issue with mongoose/mongodb dep though... updating those shortly.

I would assume the fetchRaw() is working as it is, but if you want me to add authentication to that, I could do that.

Well as you know it probably isn't. I'll look at the PR in a bit but I'll probably have to try that VPS side directly since dev environment doesn't even process the webhook. If @sizzlemctwizzle would be available to review #1729 that would be appreciated.

some of the new versions haven't been loaded from github for some time

I see a date updated difference on one of those. Although I just did my usual "Hello, World" test push and it sync'd well. You could be running into GH throttling with #1705 but unsure atm.

[joeytwiddle]

We return the http status codes that shows up in your webhook logs on GH only.

Thanks, I didn't realise those existed! (Here is my hooks link for my convenience only.)

I can report that I have been receiving 202s back from all the hook calls. (Both before and after your recent changes.)

I'm also happy to report that one update I made on 17th August did reach the website:

• https://openuserjs.org/scripts/joeytwiddle/Github_Notifications_Dropdown

However other scripts have not been updated, including this one which I updated just now (at 2020-08-21T08:56:12.140Z in 2afd89f):

• https://openuserjs.org/scripts/joeytwiddle/Related_Links_Pager

Although the webhooks logs show I did get a 202 back from OUJS. (From GitHub's request with X-GitHub-Delivery: 30cbe1e8-e38c-11ea-819d-aa45fe493647)

Please let me know if there is anything I can do to help. Cheers.

[Martii]

@joeytwiddle

Do you have some debugging information about which part of the hooks process has a problem?

When you next update on GH try a visit to your profile page, while logged into OUJS, and check the Syncs menu item in the profile nav bar and let me know if there are any issues. This hasn't been fully tested but mostly tested and should be a good start for you.

[Martii]

@joeytwiddle

I was watching as you did this....

Your script has a @license currently of AGPL-3.0...

The SPDX codes changed at some point to be one of these:

AGPL-3.0-only or AGPL-3.0-or-later.

That's why you are getting a failure on the script you tried to sync a few moments ago.

[joeytwiddle]

Great work Marti, thanks a lot for this.

I can report that the message is helpfully appearing on the /syncs page

@license is not OSI primary and compatible in the metadata block(s).

That makes it much easier to debug. The script in question is now updated! And I will proceed to fix the various other script(s) at my end.

(I'm not sure why GPL-3.0 failed - possibly caching although I didn't find any in the code - but anyway your suggestion AGPL-3.0-or-later worked, and that's what I was really after.)

[joeytwiddle]

A small suggestion: Reverse the order of the log messages, so most recent is at the top.

That's how GitHub presents its hooks logs (it's common to present notifications in general), and it will make it "easier" to see the latest log when there are many in the list.

[Martii]

A small suggestion: Reverse the orderof the log messages, so most recent is at the top.

That is the default here.

[joeytwiddle]

Ah I see. It's different depending which tab I choose. 👍

[Martii]

Hope this helps diagnose things when I'm not here... I still have a lot to do in these areas but had a few hours to throw this together since it's a common question. Glad you like it. :)

[joeytwiddle]

Recently on my Syncs page I am getting a lot of "Updating but no script found."

I think some years ago GM for Firefox might have lowercased all my script names, and I went along with it. [Edit: Never mind. This was not the reason.]

I can rename the file, but this is a bit of a hassle (and breaks some of my own processes).

Would it be possible to make the findDeadorAlive() query case-insensitive?

(And maybe fall back to a case-sensitive search, if multiple case-insensitive matches were found.)

[Edit: Forget this suggestion. As Marti explains, that wasn't the problem.]

Update: This was happening with iMDB_Large_Images.user.js but I have now deleted that, and imported imdb_large_images.user.js

[Martii]

Would it be possible to make the findDeadorAlive() query case-insensitive?

Nope. I'm the one that was instructed to make it case sensitive and it should always be. See #656 (comment) and forward in that issue. (lots of links in there too)

Picking on one of your sync's at https://raw.githubusercontent.com/joeytwiddle/code/master/other/gm_scripts/wikimedia/wikimedia.user.js#bypass=true ... that isn't on OUJS with the @name of Wikimedia Page History in Sidebar [adopted] (unsanitized for GM naming atm). And the only "Wikimedia" in a search you have is here. This doesn't remotely resemble the GH @name.

• https://raw.githubusercontent.com/joeytwiddle/code/master/other/gm_scripts/imdb_large_images/iMDB_Large_Images.user.js#bypass=true currently shows for me 404 not found on GH ... that's could be an issue with GH.

etc.... Really don't want to go through all 40 of your scripts along with syncs to validate by hand... how about you do that and post back and I'll check those. :)

As you may have noticed we still get the update request notice if you don't publish a script to OUJS from GH's webhook... so keep that in mind. Those particular 404's you can ignore if you have not published to OUJS. However the GH issue one could be them... could be you... as long as the @name's match between GH and OUJS it should retain your stats. If you change it then you lose the stats and it normally spawns off a new script (from OUJS import) because casing is important in the engines.

[joeytwiddle]

Good point with Wikimedia +. I had renamed it so it better described what it actually did. Thanks for clarifying.

So it looks like the problem is that I recently added "[fork]" and "[adopted]" to the names of many of my scripts, to clearly distinguish which are original work and which are not. (When doing this, I did not change the filenames, just the @name.) And as you say, the changed name resulted in the loss of sync.

---

Is there any way to smoothly rename a script on OUJS?

There is a thread here where you suggested:

you could change the original script to use the new @downloadurl and something to tell them to remove the old

but that is a little more cumbersome than I had hoped.

FWIW, Freaky Gorse had no problem with my renames. It must use some different logic for linking to upstream.

I'm not sure if it's worth considering a different approach for OUJS. My naive assumption was that the filename / URL would be the unique identifier, rather than the name in the metadata. Anyway, making such a change may not be easy, even if it is desirable.

---

I did try editing the @name on the OUJS site. That ended up creating a new script, which wasn't what I had hoped for, but it was at least an easy way to do that! The new script seems to sync up fine with GitHub.

Now I should consider whether to un-rename all my scripts back to how they were before, or duplicate them and deprecate the older copies, in line with your forum suggestion. Or hack away at OUJS source code. 😉

[Martii]

had no problem with my renames.

That's because you are just a number over there ... https://greasyfork.org/en/users/8615-you_are_just_a_number_over_there

even if it is desirable.

It's not and sizzle won't agree with it either from past historical posts.

I should consider whether to un-rename all my scripts back to how they were before

Your choice... but you could have modified @description to indicate a "fork" although usually license tags and headers do that for you from the upstream source.

---

Is there any way to smoothly rename a script on OUJS?

It is smooth. Grr.