Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete separation of value and logic for Redemption #8

Closed
10 tasks done
benjaminbollen opened this issue Nov 24, 2017 · 3 comments
Closed
10 tasks done

Complete separation of value and logic for Redemption #8

benjaminbollen opened this issue Nov 24, 2017 · 3 comments
Assignees
Milestone

Comments

@benjaminbollen
Copy link
Contributor

benjaminbollen commented Nov 24, 2017

builds on #5

  • re-implement OpenSTValue.processStaking
  • re-implement OpenSTUtility.redeem
  • re-implement OpenSTValue.confirmRedemptionIntent
  • re-implement OpenSTValue.processUnstaking
  • re-implement OpenSTUtility.processRedemption
  • add utility chainId to event StakingIntentDeclared
  • add value chainId to event RedemptionIntentDeclared
  • create OpenSTValueInterface.sol and OpenSTUtilityInterface for Registrar to use
  • add OpenSTValue.processStakingForced onlyRegistrar as temporary measure until the signature of OpenSTUtility.processMinting can be carried over
  • add OpenSTUtility.processRedemptionForced onlyRegistrar as temporary measure until the signature of OpenSTValue.processUnstake can be carried over
@benjaminbollen
Copy link
Contributor Author

@kedarchandrayan the new signature for OpenSTValue.processStaking no longer requires the _uuid and returns the address of the staking contract (like OpenSTUtility.processMint returns the address of the utility token)

signature : 865102f#diff-0fda3cb74ade82450f3189d77ba9209dR205

event: ProcessedStake 865102f#diff-0fda3cb74ade82450f3189d77ba9209dR47

on OpenSTUtility I added the token address also to the event (as on ProcessedStake):
865102f#diff-e44aea7e60874b5bcf6ea3206782e8b5R70

@benjaminbollen
Copy link
Contributor Author

@kedarchandrayan updated signature for

  • OpenSTUtility.redeem
  • OpenSTUtility.RedeemSTPrime
  • OpenSTValue.confirmRedemptionIntent
    and events
  • RedemptionIntentDeclared
  • RedemptionIntentConfirmed

benjaminbollen added a commit that referenced this issue Nov 27, 2017
@benjaminbollen
Copy link
Contributor Author

benjaminbollen commented Dec 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant