Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement escrow revert #27

Closed
benjaminbollen opened this issue Dec 3, 2017 · 2 comments
Closed

implement escrow revert #27

benjaminbollen opened this issue Dec 3, 2017 · 2 comments
Milestone

Comments

@benjaminbollen
Copy link
Contributor

the funds that are put into escrow on calling OpenSTValue.stake and OpenSTUtility.redeem need to revert to the staker or redeemer after the unlockHeight is surpassed and the funds have not been processed.

Addresses #8

@benjaminbollen
Copy link
Contributor Author

benjaminbollen commented Dec 4, 2017

struggled quite a bit implement the closing pieces of the protocol for v0.9.1 to keep deployment of OpenSTUtility around 8M gas (still high but OK as on utility chain side, not Ethereum mainnet - but I wanted to constrain it at that gas consumption cost);

so an important point for 0.9.2 to move up the priority list is a further gas optimisation structuring of the code.

@benjaminbollen
Copy link
Contributor Author

rebased on #14 for measuring gas consumption (makes previous branches for gh27 obsolete)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants