Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nl r 007 creditnote fix #128

Merged
merged 7 commits into from
Mar 27, 2024
Merged

Nl r 007 creditnote fix #128

merged 7 commits into from
Mar 27, 2024

Commits on Sep 20, 2023

  1. Make sure NL-R-007 only fires on invoices, not on creditnotes (UBL) 

    NL-R-007 requires that a payment means is provided, which only makes sense if there is a payment, i.e. for positive invoices.
    Jelte Jansen committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    a7a6898 View commit details
    Browse the repository at this point in the history

  2. Make sure NL-R-007 only fires on invoices, not on creditnotes (CII) 

    NL-R-007 requires that a payment means is provided, which only makes sense if there is a payment, i.e. for positive invoices (typecode != 381).
    Jelte Jansen committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    5cc83d5 View commit details
    Browse the repository at this point in the history

  3. Add test case for update to NL-R-007 to UBL unit tests

    Jelte Jansen committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    6c84f6e View commit details
    Browse the repository at this point in the history

  4. Add test case for update to NL-R-007 to CII unit tests

    Jelte Jansen committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    e633408 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Do make PaymentMeans mandatory for negative CreditNote (UBL) 

    Addendum to the fix in a7a6898, in case the CreditNote itself is negative, the payment means should be required.
    Jelte Jansen committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    7b5032f View commit details
    Browse the repository at this point in the history

  2. Do make PaymentMeans mandatory for negative CreditNote (CII) 

    Addendum to the fix in 5cc83d5, in case the CreditNote itself is negative, the payment means should be required.
    Jelte Jansen committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    edc5743 View commit details
    Browse the repository at this point in the history

  3. Testcase updates 

    Add additional error cases for the fixes in commits 7b5032f and edc5743
    Jelte Jansen committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    8a1dae1 View commit details
    Browse the repository at this point in the history