Nl r 007 creditnote fix #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 20, 2023 14:52
NL-R-007 requires that a payment means is provided, which only makes sense if there is a payment, i.e. for positive invoices.
NL-R-007 requires that a payment means is provided, which only makes sense if there is a payment, i.e. for positive invoices (typecode != 381).
|
This PR triggered some discussion about negative creditnotes, and whether those should require payment means. I'm inclined to amend the PR to add that, so please don't merge just yet. |
added 3 commits
September 25, 2023 16:01
|
Additional checks added; paymentmeans is now mandatory for invoices with a positive amount and creditnotes with a negative amount. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for a fix in country-specific rule NL-R-007; this rule checks that a PaymentMeans is present if the payable amount is positive.
The original rule also fired on CreditNote documents, which should not happen.
In case of UBL, this is a change in the context (Invoice only); in case of CII, the assertion also succeeds if the typecode is 381.
Added a testcase for creditnotes to the unit tests as well, but I don't think I have a way to verify the unit tests themselves.