Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme MIMIC #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Theme MIMIC #1

wants to merge 1 commit into from

Conversation

Danieleeffe1
Copy link

@Danieleeffe1 Danieleeffe1 commented May 7, 2021

I have created an updated and complete package for the project which I have decided to call MIMIC.

MIMIC is a theme based on RWD_default and is inspired by the LUMA theme of Magento2

MIMIC doesn't just imitate LUMA

MIMIC is Optimization for mobile devices and more in detail;

  • Menu usability in mobile formats has been improved, making the menu always visible.

  • A scrolltop beta module downloaded for free from magentostore for magento 1 has been added when it was still active.

The full version of the module in question with advanced features can be purchased at this address:
https://store.neklo.com/scroll-up-extension-for-magento.html

Despite being a Beta the module works well

This version of the scrolltop has a custom style to better suit the MIMIC theme.

  • In the RWD theme, the field where the quantities of the products to be purchased are entered are of the "InputText" type in MIMIC they have been changed to "NUMERIC" to facilitate use with the numeric keypad of smartphones and tablets.

  • Add thumbnail product associate in Product Bundle and Product Group.

  • Add Predisposition for "sales" and "discount percentage" label

MIMIC does not add jQuery code other than RWD therefore it should not cause conflicts with modules already tested with RWD

INSTALLATION:
Download the package from github

If using filezilla:
Unzip the package in a directory of your choice
Open filezilla and drag and overwrite the APP and SKIN folders to the OpenMage root

If you upload the package directly to the server be sure to unzip the package to a temporary folder for safety.

Copy and overwrite the APP and SKIN folders in the OpenMage root.

SETUP
From the Openmage Admin

Go to: SYSTEM> CONFIGURATION> GENERAL> DESIGN
Leave unchanged
Package / package name
Themes / translations
Themes / default

Change:
Themes / Templates from "default" to "mimic"
Themes / Skins (images-css) from "default" to "mimic"
Themes / Layout from "default" to "mimic"

Go to: SYSTEM> CONFIGURATION> NEKLO> scroll to top to enable the module.

LABEL FUNCTION
as function:
by admin page> CATALOG> ATTRIBUTES

Add attribute with name "label" and insert the desired parameters, ex:

  • 10%,
  • sale,
  • offer,
    (remember to make it visible option on the product page and in the product list)

once the attribute has been associated with the product, it will be displayed above the product photo in:

  • product page,
  • product category grid,
  • product category list.

theme-mimic.zip

Latest "MINI" version with all previous improvements.

Compatible with OpenMage 20.0.11 and onwards OpenMage 20.0.11 and later (if you don't change EVERYTHING AGAIN :) ) to be installed nested in the RWD folder (I deleted the Scrolltop module, for those who want to download the previous version of mimic):

theme-mimic_minimal_1.zip

RWD_LUMA updated package (v1.1)

I have created an updated and complete package for the project which I have decided to call MIMIC.

MIMIC is a theme based on RWD_default and is inspired by the LUMA theme of Magento2

MIMIC doesn't just imitate LUMA

MIMIC is Optimization for mobile devices and more in detail;

- Menu usability in mobile formats has been improved, making the menu always visible.

- A scrolltop beta module downloaded for free from magentostore for magento 1 has been added when it was still active.

The full version of the module in question with advanced features can be purchased at this address:
https://store.neklo.com/scroll-up-extension-for-magento.html

Despite being a Beta the module works well

This version of the scrolltop has a custom style to better suit the MIMIC theme.

- In the RWD theme, the field where the quantities of the products to be purchased are entered are of the "InputText" type in MIMIC they have been changed to "NUMERIC" to facilitate use with the numeric keypad of smartphones and tablets.

MIMIC does not add jQuery code other than RWD therefore it should not cause conflicts with modules already tested with RWD

INSTALLATION:
Download the package from github

If using filezilla:
Unzip the package in a directory of your choice
Open zilla files and drag and overwrite the APP and SKIN folders to the OpenMage root

If you upload the package directly to the server be sure to unzip the package to a temporary folder for safety.

Copy and overwrite the APP and SKIN folders in the OpenMage root.

SETUP
From the Openmage Admin

Go to: SYSTEM> CONFIGURATION> GENERAL> DESIGN
Leave unchanged
   Package / package name
   Themes / translations
   Themes / default

Change:
   Themes / Templates from "default" to "mimic"
   Themes / Skins (images-css) from "default" to "mimic"
   Themes / Layout from "default" to "mimic"
  
Go to: SYSTEM> CONFIGURATION> NEKLO> scroll to top to enable the module.
@Danieleeffe1 Danieleeffe1 changed the title Update README.md - theme MIMIC Theme MIMIC May 10, 2021
@Flyingmana
Copy link
Contributor

checking and adding the zip file you attached to the repository takes a lot of time, you have to be patient till a volunteer takes this task over. to create a proper PullRquest out of it

@Danieleeffe1
Copy link
Author

Danieleeffe1 commented Jun 10, 2021 via email

@kiatng
Copy link

kiatng commented Jun 10, 2021

@Danieleeffe1 Thanks for making MIMIC available to the community. I downloaded your hefty zip and took a peek. Would you consider making MIMIC fallback to rwd? There are many advantages, one of which is the need to include every file from rwd. To allow theme fallback, replace app\design\frontend\rwd\mimic\etc\theme.xml with this

<!-- app\design\frontend\rwd\mimic\etc\theme.xml -->
<theme>
    <parent>rwd/default</parent>
</theme>

After which, you only need to retain the files which are different from rwd in the design and skin folders. This will make maintenance a lot easier should someone decide to use MIMIC. Also, from security stand point, it reduces the attack surface.

@Danieleeffe1
Copy link
Author

Danieleeffe1 commented Jun 10, 2021

kiatng

Thanks for the reply.

I had decided to propose an independent and complete file to give the possibility to those who want to modify it at their own pleasure without being bound to RWD

I have never done the procedure you suggest, I can try to do it.

II can only make available files that have been added and changed

as soon as available I will post it at the end of this chat.

@Danieleeffe1
Copy link
Author

"MIMIC" update

This file contains only and exclusively modified MIMIC files which differ from RWD to facilitate the control work.

I edited the theme.xml file as indicated by kiatng.

I have not changed the contents of the .xml files in Layout referring to the folders contained in the theme as I do not know the syntax needed to clean these files.

I have updated the header.phtml file to a new version

in this new version in mobile mode I managed to hide the logo previously above the menu-bar to save space and I replaced the word MENU with the "alt image" of the logo in order to get the wording you want (I would have put the store name but I could not find the correct php node).

I also optimized the css based.
theme-mimic_minimal.zip

@kiatng
Copy link

kiatng commented Jun 11, 2021

@Danieleeffe1 Thanks so much for the minimized version, it is much easier to review. I'm interested to test it but my workload is exremely high at the moment for the next couple of months.

Another suggestion: there are 2 modules in app\code\community\Neklo, it'll help interested reviewers if you would provide descriptions on what those modules are doing. In particular the core module, at first glance, it seems to be a little intrusive.

@Danieleeffe1
Copy link
Author

Danieleeffe1 commented Jun 11, 2021

@ Danielleeffe1 Grazie mille per la versione ridotta a icona, è molto più facile da rivedere. Sono interessato a testarlo, ma il mio carico di lavoro è estremamente alto al momento per i prossimi due mesi.

Un altro suggerimento: ci sono 2 moduli in app\code\community\Neklo, sarà utile ai revisori interessati se fornireste descrizioni su cosa stanno facendo quei moduli. In particolare il coremodulo, a prima vista, sembra essere un po' invadente.

kind kiatng

the module was present in free license in magentostore before it was closed.

I quote original description of mimic:

"A scrolltop beta module downloaded free from magentostore for magento 1 was added when the store was still active.

The full version of the module in question with advanced features can be purchased at this address:

https://store.neklo.com/scroll-up-extension-for-magento.html "

I don't know the way it works, I'm not a developer.
I found a free and very simple scroll top for magento 2.

https://magefan.com/blog/magento-2-scroll-to-top-free-solutionl
This scroll top can be created as a static block in a simple widget.
I have tried to migrate this script to OpenMage but it doesn't work.

@Danieleeffe1
Copy link
Author

Danieleeffe1 commented Jul 8, 2021

add media.phtml in app/design/rwd/mimic/template/catalog/product/view

in this file add two function :

  1. label (for percentual sales)
  2. add viedo file under image gallery (is necessary create attribute txt for insert url)

media.phtml.zip

@Danieleeffe1
Copy link
Author

Danieleeffe1 commented Jul 28, 2021

New Update:

i have modifed the css file, now i n the page product the button add-to-link wishlist and the button add-to-link compare in the product page have the icon heart and icon grafics.

is sufficents add the follow files modifed:

style.css in the pat skin/frontend//rwd/mimic/css/
xicon_sprites.png in the pat skin/frontend/rwd/mimic/images/

style-and-xicon-sprite.zip

@Danieleeffe1
Copy link
Author

Danieleeffe1 commented Sep 6, 2021

Latest "MINI" version with all previous improvements.

Compatible with OpenMage 20.0.11 and onwards OpenMage 20.0.11 and later (if you don't change EVERYTHING AGAIN :) ) to be installed nested in the RWD folder (I deleted the Scrolltop module, for those who want to download the previous version of mimic):

theme-mimic_minimal_1.zip

pending approval and publication

@Danieleeffe1
Copy link
Author

@Danieleeffe1 Thanks so much for the minimized version, it is much easier to review. I'm interested to test it but my workload is exremely high at the moment for the next couple of months.

Another suggestion: there are 2 modules in app\code\community\Neklo, it'll help interested reviewers if you would provide descriptions on what those modules are doing. In particular the core module, at first glance, it seems to be a little intrusive.

Hello Kiatng

I have loaded the latest essential version of Mimic.

I deleted the Neklo module which inserts the TopScroll function (to make your life easier) and deleted the file /app/design/frontend/rwd/mimic/layout/page.xml which prevented the loading of css files with OpenMage 20.0.11 and above .

If you read the various updates of the post history you will see that I have added a couple of changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants