Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Danieleeffe1 Thanks so much for the minimized version, it is much easier to review. I'm interested to test it but my workload is exremely high at the moment for the next couple of months. #2

Closed
Danieleeffe1 opened this issue Sep 6, 2021 · 0 comments

Comments

@Danieleeffe1
Copy link

@Danieleeffe1 Thanks so much for the minimized version, it is much easier to review. I'm interested to test it but my workload is exremely high at the moment for the next couple of months.

Another suggestion: there are 2 modules in app\code\community\Neklo, it'll help interested reviewers if you would provide descriptions on what those modules are doing. In particular the core module, at first glance, it seems to be a little intrusive.

Originally posted by @kiatng in #1 (comment)

Hello Kiatng

I have loaded the latest essential version of Mimic.

I deleted the Neklo module which inserts the TopScroll function (to make your life easier) and deleted the file /app/design/frontend/rwd/mimic/layout/page.xml which prevented the loading of css files with OpenMage 20.0.11 and above .

If you read the various updates of the post history you will see that I have added a couple of changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant